cli: Add show-startup-logs flag to reduce startup log verbosity
#1218
Conversation
|
Thank you for opening this PR! While I agree that it's useful to control the startup logs, I am not sure if a dedicated flag is the best approach. In #1216 (comment), I propose the idea of adding a generic flag for controlling the log level. If the log level does allow info messages, the startup logs would not be printed. Feel free to join the discussion in the other issue and let us know what you think. This would also help us to remove the additional |
|
Thanks for the feedback. |
cmd/tusd/cli/composer.go
Outdated
| if Flags.S3Endpoint == "" { | ||
| if Flags.S3TransferAcceleration { | ||
| stdout.Printf("Using 's3://%s' as S3 bucket for storage with AWS S3 Transfer Acceleration enabled.\n", Flags.S3Bucket) | ||
| if Flags.ShowStartupLogs { |
There was a problem hiding this comment.
I think a better interface would be to have a function, printStartupLogLine, that does the ShowStartupLogs checks but is otherwise a wrapper for stdout.PrintF.
That'd avoid the excessive indentation here, as well as being likely a lot more robust to refactoring.
There was a problem hiding this comment.
That makes sense to me.
@Acconut what do you think about this?
There was a problem hiding this comment.
You can probably just try implementing it; it's easier for maintainers to review a concept like this after seeing it. The current version seems unlikely to be merged.
There was a problem hiding this comment.
Sure, I'll update this PR 👍
Thanks Tim!
|
I've made the updations. |
This adds the 'show-startup-logs' flag to the tusd server, allowing the user to enable or disable startup logs. This helps the user suppress startup logs as per their preference. Fixes tus#1216.
Acconut
changed the title
show-startup-logs flag to reduce startup log verbosity
Thanks a lot @Acconut! |
Previously, tusd printed unnecessary logs on startup while running the tools/run-dev script. This commit resolves the issue by setting the verbose flag to false, which defaults to true if not specified. The required PR adding this flag was introduced in tus/tusd#1218. Fixes zulip#32301.
This enables the user to enable or disable the startup logs while starting the tusd server. It helps the user suppress the startup logs as per their preference.
The flag has a default value of true.
Fixes #1216.
Before:
After:
set as false:
set as true explicity:
default:
