Remove storage entry if resumable storage has been enabled and the stored URL has been voided

[pandabear]

This pull request aims to resolve the issue #103 .

This change introduces a logic handler when initializing a new Uploader instance with storage-enabled to not only clean up voided storage key entry, but also make the usage more user-friendly as no extra effort is required to initialize a resumable feature. tus-js-client was referenced https://github.com/tus/tus-js-client/blob/bef505f2fb751095af06e3a9bdf62384df136a7a/lib/upload.ts#L697-L705 to determine how this case is handled. Otherwise retain the same logic as before.

• Add a test case that simulates the issue
• Implement try-except special handling case to prevent voided storage key entry from causing errors during Uploader-instance initialization

[Acconut]

Thank you very much for opening this PR!

[Acconut]

Thank you very much. The test logic looks good now, but CI is failing on Windows due to PermissionError: [Errno 13] Permission denied: 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpevpkhklg'. Can you please have a look at this?

[jukuisma]

PermissionError: [Errno 13] Permission denied: 'C:\Users\RUNNER~1\AppData\Local\Temp\tmpevpkhklg'

https://docs.python.org/3/library/tempfile.html#tempfile.NamedTemporaryFile /windows seems related.

[pandabear]

Thank you very much. The test logic looks good now, but CI is failing on Windows due to PermissionError: [Errno 13] Permission denied: 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpevpkhklg'. Can you please have a look at this?

I noticed earlier with named temporary folders. Perhaps it's the use of context manager that messes up with windows logic. 3.12 introduces delete_on_close parameter, but that won't be much help for earlier Windows python versions.

Nevertheless, I updated the test to not rely on context manager. If this also fails then only thing left is to create a file during test runtime within tests-folder, like how it was done in test_filestorage.py -module.

[Acconut]

I just ran CI tests again, but unfortunately it didn't seem to help so far.

[pandabear]

I just ran CI tests again, but unfortunately it didn't seem to help so far.

My last attempt before I ditch tempfile. My guess it's the storagethat was occupying the temporary file.

[Matoking]

NamedTemporaryFile(delete=True, delete_on_close=False) works nicely on Wine, while reproducing the permission error with delete_on_close=True. Something to do with deletion rights that tempfile tries to request by default upon opening the file?

python/cpython#88221 (comment)

But as @pandabear stated, delete_on_close is only available on Python 3.12 and up, so probably not an option here...

[Acconut]

Thank you! Looks all good now!