Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to TypeScript: Upload, StreamSource #734

Merged
merged 7 commits into from
Nov 13, 2024

Conversation

holloway
Copy link

@holloway holloway commented Nov 2, 2024

Adding some types for browser StreamSource

@holloway
Copy link
Author

holloway commented Nov 2, 2024

fyi @Acconut

@holloway holloway changed the title Move to TypeScript: StreamSource Move to TypeScript: Upload, StreamSource Nov 2, 2024
Acconut and others added 5 commits November 13, 2024 13:21
* setHeader value arg should be string

* Explicit casting of header values, number to string

* Fix syntax

* Fix lint

---------

Co-Authored-By: Marius Kleidl <[email protected]>
Co-Authored-By: Marius Kleidl <[email protected]>
Copy link
Member

@Acconut Acconut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your help! I pushed a few additional commits to make the test suite pass. Notably, the bytesTotal argument for progress events can be null. This was previously not properly documented and TypeScript helped discover this 🙌

@Acconut Acconut merged commit f97916d into tus:typescript2 Nov 13, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants