Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify bytecode emitters #844

Merged
merged 2 commits into from
Feb 1, 2025
Merged

Conversation

glommer
Copy link
Contributor

@glommer glommer commented Jan 31, 2025

Instead of always having the caller specify all instructions, this
work introduces convenience functions into the program builder,
making the code a lot cleaner.

Draft for now, as this is done on top of #841 

If we keep the pragma list sorted when declaring it, we can avoid
a vector allocation when printing the pragma_list.
Instead of always having the caller specify all instructions, this
work introduces convenience functions into the program builder,
making the code a lot cleaner.
@penberg penberg changed the title simplify the writing of bytecode programs Simplify bytecode emitters Jan 31, 2025
@glommer glommer marked this pull request as ready for review January 31, 2025 16:36
@glommer glommer mentioned this pull request Jan 31, 2025
@penberg penberg merged commit db29f43 into tursodatabase:main Feb 1, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants