Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full flake overhaul #835

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Full flake overhaul #835

merged 1 commit into from
Feb 1, 2025

Conversation

levydsa
Copy link
Contributor

@levydsa levydsa commented Jan 30, 2025

Improvements:

  • Use rust-overlay, better maintained than fenix and allows for:
  • Use rust-toolchain.toml as the source of truth for the current rust version, instead of tracking with stable. Preventing conflicting versions with non-nix users.
  • Add flake checks, could be useful for CI in the future, together with crane and cachix.
  • Add package, allow people to add limbo as a regular nix package. Now we can nix build .#, nix run .# and nix shell .# (this one adds limbo to the current PATH)
  • Use new apple-sdk pattern, no need to declare each framework now.

@penberg
Copy link
Collaborator

penberg commented Feb 1, 2025

@levydsa I am merging this and hoping that any issues that pop up, you just deal with. Including people complaining that the configuration does not match their preferences 😝. And this becomes a never-ending thing, we'll probably just drop the stuff from the tree.

@penberg penberg closed this in 51f0c9e Feb 1, 2025
@penberg penberg merged commit 51f0c9e into tursodatabase:main Feb 1, 2025
39 checks passed
@penberg penberg mentioned this pull request Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants