Elijah/add web interface #759
Open
+422
−305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build appears to work - test-limbo-pkg works cleanup test-limbo-pkg vite fs allow
make interface.ts/js the entry point for the module
jussisaurio
reviewed
Jan 21, 2025
| @@ -15,16 +15,18 @@ | |||
| "exports": { | |||
| ".": { | |||
| "node": "./node/dist/index.cjs", | |||
| "browser": "./web/dist/index.js", | |||
| "browser": "./web/dist/interface.js", | |||
There was a problem hiding this comment.
Should default also be interface.js? Further, perhaps this should be sth like
"node": {
"import": "./node/dist/index.mjs", // if we have ES module support in node, i dont remember
"require": "./node/dist/index.cjs",
},
"browser": {
"import": "./web/dist/interface.js",
"require": "???"
}
jussisaurio
approved these changes
Jan 21, 2025
|
This shouldn't go in quite yet - I'm trying to fix up a weird tsc compile step issue where tsc puts a dist dir inside of dist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an interface to the limbo-worker.js for browser.
Make interface the entry point of the module - see
test-limbo-pkg/index.htmlfor an example.resolves #756