-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralize Rust integration and regression tests #753
Centralize Rust integration and regression tests #753
Conversation
clippy 😁 -> todo |
@PThorpe92 @jussisaurio @pereman2 please have a look. I think we should do this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looketh goodeth to meeth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename journal
to wal
? Limbo does not have a journal
mode so I think it is misleading.
Moreover, I find it confusing now because before I had all my insert
tests in a single place where I could easily just jump around the file. Now I have test_wal.rs
test_insert.rs
and test_overflow.rs
which all have a single function in them which makes, imho, hard to navigate.
@pereman2 What would you prefer here? All I want to do is move tests to top-level |
@penberg Just merge |
c530885
to
a090fb9
Compare
hey guys thanks for the reviews! @penberg @pereman2 @jussisaurio @PThorpe92 I made some changes
It is ready to go in now. BTW this is a bit off topic, but there is also the journal_mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! wal
will be the only journal mode supported that's why I proposed that.
What?
Why?