Implement Not #748
Merged
Implement Not #748
+59
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jussisaurio
reviewed
Jan 19, 2025
| OwnedValue::Integer(i) => OwnedValue::Integer((*i == 0) as i64), | ||
| OwnedValue::Float(f) => OwnedValue::Integer((*f == 0.0) as i64), | ||
| OwnedValue::Text(text) => exec_boolean_not(&cast_text_to_numerical(&text.value)), | ||
| _ => todo!(), |
There was a problem hiding this comment.
Can this be a panic! instead with an error message that this should not happen on other_type
There was a problem hiding this comment.
Agreed, I just kept the same logic from other functions like exec_bit_not .
We should probably fix it across all these functions. Will try to make a PR for this.
There was a problem hiding this comment.
@jussisaurio @psvri We're a library, perhaps it's better to never panic, actually.
jussisaurio
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Not operator and Opcode.