WIP - rewrite_expr: simplify binary expressions whenever possible #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jussisaurio
force-pushed
the
rewrite-expr-simply-binary-exprs
branch
from
039f858 to
903c11c
Compare
|
@jussisaurio Merge conflict |
jussisaurio
force-pushed
the
rewrite-expr-simply-binary-exprs
branch
from
903c11c to
0df158c
Compare
jussisaurio
changed the title
jussisaurio
force-pushed
the
rewrite-expr-simply-binary-exprs
branch
from
0df158c to
5a9c602
Compare
jussisaurio
force-pushed
the
rewrite-expr-simply-binary-exprs
branch
from
5a9c602 to
a1d0c27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚫 Don't merge this yet, I think there's still bugs
Adds logic for, after other expression rewriting is done, to simplify any binary expressions that either were originally, or have become trivially true or false post-rewriting. it also rewrites things like
x OR falseto be justxThis came about during investigating the fix for #698, not essential at this stage but since i had sketched it out anyway, here it is.