Use the correct integer PK column idx as the row-id alias #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvos94
force-pushed
the
graghura/alias_integer_pk_as_rowid
branch
from
b3b2fa2 to
8a34c16
Compare
penberg
added a commit
that referenced
this pull request
Sep 22, 2024
…m GV This pull request addresses [issue #256](https://github.com/penberg/limbo/issues/256). However, it currently breaks insertions into tables that lack a row-id alias due to the NewRowId not being implemented yet. I have created an [issue](https://github.com/penberg/limbo/issues/275) to track this problem and will submit a separate pull request to resolve it soon. Closes #274
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #256.
However, it currently breaks insertions into tables that lack a row-id alias due to the NewRowId not being implemented yet. I have created an issue to track this problem and will submit a separate pull request to resolve it soon.