Clean up extension types API, introduce json text subtype #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PThorpe92
force-pushed
the
ext_types_ownership
branch
from
c0c09d8 to
755b215
Compare
PThorpe92
force-pushed
the
ext_types_ownership
branch
from
aa06065 to
741c4e8
Compare
PThorpe92
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up some comments in the extension API and prevents extensions themselves from calling 'free' on Value types that are exposed to the user facing traits, as well as changes the
from_ffimethod for OwnedValues to take ownership and automatically free the values to prevent memory leaks.This PR also finds the name of the
args: &[Value]argument for scalar functions in extensions, and uses that in the proc macro, instead of relying on documentation to communicate that the parameter must be namedargs.