-
Notifications
You must be signed in to change notification settings - Fork 310
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge 'implement is and is not where constraints' from Glauber Costa
The main difference between = and != is how null values are handled. SQLite passes a flag "NULLEQ" to Eq and Ne to disambiguate that. In the presence of that flag, NULL = NULL. Some prep work is done to make sure we can pass a flag instead of a boolean to Eq and Ne. I looked into the bitflags crate but got a bit scared with the list of dependencies. Warning: The following query produces a different result for Limbo: ``` select * from demo where value is null or id == 2; ``` I strongly suspect the issue is with the OR implementation, though. The bytecode generated is quite different. Reviewed-by: Jussi Saurio <[email protected]> Closes #847
- Loading branch information
Showing
11 changed files
with
301 additions
and
85 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.