Avoid dynamic require of the native package (2nd attempt)#204
Open
bgw wants to merge 1 commit intotursodatabase:v0.5from
Open
Avoid dynamic require of the native package (2nd attempt)#204bgw wants to merge 1 commit intotursodatabase:v0.5from
bgw wants to merge 1 commit intotursodatabase:v0.5from
Conversation
1 task
|
@penberg hi! could you please review this PR? |
Author
|
@Lilja, if you're blocked on this, you can work around it by doing one of the following:
|
|
@bgw Thanks for the suggestions! I'm using bun and I am bundling a typescript backend with Elysia so I'm afraid I can't use Next.js. Right now I'm externalizing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR against the v0.5 branch
This is a second attempt at #200, which was reverted due to a regression in esbuild (#201).
This is an attempted fix/mitigation for vercel/next.js#82881 (comment)
Apparently esbuild requires try/catch blocks to make failing non-dynamic
requires throw a runtime instead of at build time. #201This new implementation more closely matches the pattern used on the
mainbranch:libsql-js/index.js
Lines 31 to 311 in 31bed66
I tested this against the minimal repro at https://github.com/RomanHotsiy/libsql-bug-repro
I can't get the code built by esbuild that repro to run (
node dist/index.js):mjstocjsto get node to run it*.nodefile has to be handled somehow, which the repro doesn't doHowever that repro now builds cleanly (
npm run build), which is all I think it's really intended to show.