Logan Anderson #442
Open
Logan Anderson #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Trying to fix error message when pushing"
ap2322
reviewed
Jan 17, 2021
ap2322
left a comment
ap2322
left a comment
There was a problem hiding this comment.
Logan, overall great work on this. Good job getting into extensions too!
Comment on lines
+4
to
+9
| if frog == 1 | ||
| puts "#{frog} speckled frog sat on a log eating some most delicious bugs. One jumped in the pool where its nice and cool, then there were no more speckled frogs!" | ||
| elsif frog == 2 | ||
| puts "#{frog} speckled frogs sat on a log eating some most delicious bugs. One jumped in the pool where its nice and cool, then there was #{frog - 1} speckled frog." | ||
| else | ||
| puts "#{frog} speckled frogs sat on a log eating some most delicious bugs. One jumped in the pool where its nice and cool, then there were #{frog - 1} speckled frogs." |
There was a problem hiding this comment.
Nice work catching the different cases. Refactor consideration: How might you DRY up the repeated phrases in here?
Comment on lines
+29
to
+44
| if number % 3 == 0 && number % 5 == 0 && number == ending_num | ||
| print "FizzBuzz " | ||
| elsif number % 3 == 0 && number == ending_num | ||
| print "Fizz " | ||
| elsif number % 5 == 0 && number == ending_num | ||
| print "Buzz " | ||
| elsif number == ending_num | ||
| print "#{number} " | ||
| elsif number % 3 == 0 && number % 5 == 0 && !(number == ending_num) | ||
| print "FizzBuzz, " | ||
| elsif number % 3 == 0 && !(number == ending_num) | ||
| print "Fizz, " | ||
| elsif number % 5 == 0 && !(number == ending_num) | ||
| print "Buzz, " | ||
| else | ||
| print "#{number}, " |
There was a problem hiding this comment.
This large conditional is ripe for refactoring.
Comment on lines
+15
to
+25
| def add_topping(new_topping) | ||
| toppings << new_topping | ||
| end | ||
|
|
||
| def remove_topping(bad_topping) | ||
| toppings.delete(bad_topping) | ||
| end | ||
|
|
||
| def change_protein(new_protein) | ||
| @protein = new_protein | ||
| end |
There was a problem hiding this comment.
Nice work modifying the class attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mod 1 Pre-work.