Kon Ham #428
Kon Ham #428
Conversation
ap2322
left a comment
ap2322
left a comment
There was a problem hiding this comment.
Kon, Great work on this! I left some high level notes on where you could think about refactoring your code.
| frogs -= 1 | ||
| puts "then there were #{frogs} speckled frogs." | ||
| end | ||
| if frogs === 1 |
There was a problem hiding this comment.
Question for you to research: What's the difference in Ruby between =, ==, and ===?
| if high % 15 === 0 | ||
| print "FizzBuzz" | ||
| elsif high % 5 === 0 | ||
| print "Buzz" | ||
| elsif high % 3 === 0 | ||
| print "Fizz" |
There was a problem hiding this comment.
Seems like these lines are repeated from inside your while loop. This is a good candidate to refactor so you don't have repeating conditionals with the same output.
| Let's make a function that will take two parameters: the string that the user wants to encrypt, and the number of degrees we will shift our alphabet to the left. | ||
|
|
||
| `def caesar_cipher(string, degrees)` |
There was a problem hiding this comment.
Nice work making a clear step-by-step document with some code snippets to illustrate the explanation of how you'll go about making a caesar cipher.
| def add_topping(topping) | ||
| toppings.push(topping) | ||
| end | ||
|
|
||
| def remove_topping(topping) | ||
| toppings.delete(topping) | ||
| end | ||
|
|
||
| def change_protein(protein) | ||
| self.protein = protein | ||
| end |
There was a problem hiding this comment.
Another way of updating the attributes directly is to use the instance variable @protein (or @toppings).
2 participants
Here is my prework!