Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table azure_spring_cloud_app Closes #713 #718

Closed
wants to merge 5 commits into from
Closed

Conversation

ParthaI
Copy link
Contributor

@ParthaI ParthaI commented Jan 15, 2024

Integration test logs

Logs
No env file present for the current environment:  staging 
 Falling back to .env config
No env file present for the current environment:  staging
customEnv TURBOT_TEST_EXPECTED_TIMEOUT undefined

SETUP: tests/azure_spring_cloud_app []

PRETEST: tests/azure_spring_cloud_app

TEST: tests/azure_spring_cloud_app
Running terraform

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # azurerm_resource_group.named_test_resource will be created
  + resource "azurerm_resource_group" "named_test_resource" {
      + id       = (known after apply)
      + location = "eastus"
      + name     = "turbottest95879"
    }

  # azurerm_spring_cloud_app.named_test_resource will be created
  + resource "azurerm_spring_cloud_app" "named_test_resource" {
      + fqdn                = (known after apply)
      + https_only          = false
      + id                  = (known after apply)
      + is_public           = false
      + name                = "turbottest95879"
      + resource_group_name = "turbottest95879"
      + service_name        = "turbottest95879"
      + tls_enabled         = false
      + url                 = (known after apply)

      + identity {
          + principal_id = (known after apply)
          + tenant_id    = (known after apply)
          + type         = "SystemAssigned"
        }
    }

  # azurerm_spring_cloud_service.named_test_resource will be created
  + resource "azurerm_spring_cloud_service" "named_test_resource" {
      + id                             = (known after apply)
      + location                       = "eastus"
      + name                           = "turbottest95879"
      + outbound_public_ip_addresses   = (known after apply)
      + required_network_traffic_rules = (known after apply)
      + resource_group_name            = "turbottest95879"
      + sku_name                       = "S0"
    }

Plan: 3 to add, 0 to change, 0 to destroy.

Changes to Outputs:
  + region             = "eastus"
  + resource_aka       = (known after apply)
  + resource_aka_lower = (known after apply)
  + resource_id        = (known after apply)
  + resource_name      = "turbottest95879"
  + subscription_id    = "3510ae4d-530b-497d-8f30-53b9616fc6c1"
azurerm_resource_group.named_test_resource: Creating...
azurerm_resource_group.named_test_resource: Creation complete after 4s [id=/subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourceGroups/turbottest95879]
azurerm_spring_cloud_service.named_test_resource: Creating...
azurerm_spring_cloud_service.named_test_resource: Still creating... [10s elapsed]
azurerm_spring_cloud_service.named_test_resource: Still creating... [20s elapsed]
azurerm_spring_cloud_service.named_test_resource: Still creating... [30s elapsed]
azurerm_spring_cloud_service.named_test_resource: Still creating... [40s elapsed]
azurerm_spring_cloud_service.named_test_resource: Still creating... [50s elapsed]
azurerm_spring_cloud_service.named_test_resource: Still creating... [1m0s elapsed]
azurerm_spring_cloud_service.named_test_resource: Still creating... [1m10s elapsed]
azurerm_spring_cloud_service.named_test_resource: Still creating... [1m20s elapsed]
azurerm_spring_cloud_service.named_test_resource: Still creating... [1m30s elapsed]
azurerm_spring_cloud_service.named_test_resource: Still creating... [1m40s elapsed]
azurerm_spring_cloud_service.named_test_resource: Still creating... [1m50s elapsed]
azurerm_spring_cloud_service.named_test_resource: Still creating... [2m0s elapsed]
azurerm_spring_cloud_service.named_test_resource: Still creating... [2m10s elapsed]
azurerm_spring_cloud_service.named_test_resource: Creation complete after 2m14s [id=/subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourceGroups/turbottest95879/providers/Microsoft.AppPlatform/Spring/turbottest95879]
azurerm_spring_cloud_app.named_test_resource: Creating...
azurerm_spring_cloud_app.named_test_resource: Still creating... [10s elapsed]
azurerm_spring_cloud_app.named_test_resource: Still creating... [20s elapsed]
azurerm_spring_cloud_app.named_test_resource: Still creating... [30s elapsed]
azurerm_spring_cloud_app.named_test_resource: Creation complete after 34s [id=/subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourceGroups/turbottest95879/providers/Microsoft.AppPlatform/Spring/turbottest95879/apps/turbottest95879]

Apply complete! Resources: 3 added, 0 changed, 0 destroyed.

Outputs:

region = "eastus"
resource_aka = "azure:///subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourceGroups/turbottest95879/providers/Microsoft.AppPlatform/Spring/turbottest95879"
resource_aka_lower = "azure:///subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourcegroups/turbottest95879/providers/microsoft.appplatform/spring/turbottest95879/apps/turbottest95879"
resource_id = "/subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourceGroups/turbottest95879/providers/Microsoft.AppPlatform/Spring/turbottest95879/apps/turbottest95879"
resource_name = "turbottest95879"
subscription_id = "3510ae4d-530b-497d-8f30-53b9616fc6c1"

Running SQL query: test-get-query.sql
Warning: terminal options has been deprecated and will be removed in a future version of Steampipe.
These can now be set in a steampipe workspace.
(/Users/parthas/.steampipe/config/default.spc:34,20-42,2)
[
  {
    "id": "/subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourceGroups/turbottest95879/providers/Microsoft.AppPlatform/Spring/turbottest95879/apps/turbottest95879",
    "name": "turbottest95879",
    "region": "eastus",
    "resource_group": "turbottest95879",
    "subscription_id": "3510ae4d-530b-497d-8f30-53b9616fc6c1"
  }
]
✔ PASSED

Running SQL query: test-list-query.sql
Warning: terminal options has been deprecated and will be removed in a future version of Steampipe.
These can now be set in a steampipe workspace.
(/Users/parthas/.steampipe/config/default.spc:34,20-42,2)
[
  {
    "id": "/subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourceGroups/turbottest95879/providers/Microsoft.AppPlatform/Spring/turbottest95879/apps/turbottest95879",
    "name": "turbottest95879",
    "region": "eastus",
    "resource_group": "turbottest95879",
    "subscription_id": "3510ae4d-530b-497d-8f30-53b9616fc6c1"
  }
]
✔ PASSED

Running SQL query: test-not-found-query.sql
Warning: terminal options has been deprecated and will be removed in a future version of Steampipe.
These can now be set in a steampipe workspace.
(/Users/parthas/.steampipe/config/default.spc:34,20-42,2)
[]
✔ PASSED

Running SQL query: test-turbot-query.sql
Warning: terminal options has been deprecated and will be removed in a future version of Steampipe.
These can now be set in a steampipe workspace.
(/Users/parthas/.steampipe/config/default.spc:34,20-42,2)
[
  {
    "akas": [
      "azure:///subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourceGroups/turbottest95879/providers/Microsoft.AppPlatform/Spring/turbottest95879/apps/turbottest95879",
      "azure:///subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourcegroups/turbottest95879/providers/microsoft.appplatform/spring/turbottest95879/apps/turbottest95879"
    ],
    "name": "turbottest95879",
    "title": "turbottest95879"
  }
]
✔ PASSED

TEARDOWN: tests/azure_spring_cloud_app

SUMMARY:

1/1 passed.

Example query results

Results
> select * from azure_spring_cloud_app
+--------+-----------------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------+---------------+----------+--------+--------------------+------------------------>
| name   | id                                                                                                                                            | type                              | service_name  | location | public | provisioning_state | created_time           >
+--------+-----------------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------+---------------+----------+--------+--------------------+------------------------>
| test34 | /subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourceGroups/turbot_rg/providers/Microsoft.AppPlatform/Spring/testservice43/apps/test34 | Microsoft.AppPlatform/Spring/apps | testservice43 | eastus   | false  | Succeeded          | 2024-01-15T20:40:46+05:>
| testpy | /subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourceGroups/turbot_rg/providers/Microsoft.AppPlatform/Spring/testservice43/apps/testpy | Microsoft.AppPlatform/Spring/apps | testservice43 | eastus   | false  | Succeeded          | 2024-01-15T20:40:46+05:>
+--------+-----------------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------+---------------+----------+--------+--------------------+------------------------>


> select * from azure_spring_cloud_app where name = 'test34' and service_name = 'testservice43' and resource_group = 'turbot_rg'
+--------+-----------------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------+---------------+----------+--------+--------------------+------------------------>
| name   | id                                                                                                                                            | type                              | service_name  | location | public | provisioning_state | created_time           >
+--------+-----------------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------+---------------+----------+--------+--------------------+------------------------>
| test34 | /subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourceGroups/turbot_rg/providers/Microsoft.AppPlatform/Spring/testservice43/apps/test34 | Microsoft.AppPlatform/Spring/apps | testservice43 | eastus   | false  | Succeeded          | 2024-01-15T20:40:46+05:>
+--------+-----------------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------+---------------+----------+--------+--------------------+-----------------------



@ParthaI ParthaI self-assigned this Jan 15, 2024
@ParthaI ParthaI linked an issue Jan 15, 2024 that may be closed by this pull request
@ParthaI
Copy link
Contributor Author

ParthaI commented Feb 2, 2024

  • Currently, the table utilizes the AppsClient.List API call with the 2020-07-01 API version, which has been deprecated.
  • Attempting to make the API call with the 2020-07-01 version results in an UnsupportedApiVersion error.
  • According to Azure's API documentation, the current API version is 2023-12-01. The API version 2020-07-01 was working fine until 14th January 2024.
  • To integrate this table, it's necessary to adopt the package github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/appplatform/armappplatform.
  • Updating the SDK used by the Steampipe plugin for Azure is required, which may introduce breaking changes.

This PR is therefore being marked as on hold.

Copy link

github-actions bot commented Apr 2, 2024

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Apr 2, 2024
Copy link

github-actions bot commented May 3, 2024

This PR was closed because it has been stalled for 90 days with no activity.

@github-actions github-actions bot closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale No recent activity has been detected on this issue/PR and it will be closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add table azure_spring_cloud_app
2 participants