use Zstd for wiHelper::Compress #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brakhane
force-pushed
the
zstd
branch
4 times, most recently
from
bc57261 to
e2b1c2b
Compare
turanszkij
approved these changes
Jan 12, 2025
|
That's great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZStd has better compression and is faster as well:
Before (Deflate):
Total compressed: 48927172 -> 12048973 (24%)
[Wicked Engine Offline Shader Compiler] ShaderDump written to wiShaderDump.h in 8.864 seconds
Now:
Total compressed: 48927172 -> 8954159 (18%)
[Wicked Engine Offline Shader Compiler] ShaderDump written to wiShaderDump.h in 0.7831 seconds
(It's also possible to use a higher compression level than 3, but 3 usually works well enough. Just for fun, I tested with the extreme setting 19, it reduced it to 16%, but took a whopping 21 seconds.)