Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(packages/tuono-router): replace zustand with React.Context #256

Merged
merged 6 commits into from
Dec 24, 2024
Merged

feat(packages/tuono-router): replace zustand with React.Context #256

merged 6 commits into from
Dec 24, 2024

Conversation

Valerioageno
Copy link
Member

Context & Description

As required by the React19 migration, this PR turn the router zustand store into a react context.

Closes: #247

@Valerioageno Valerioageno self-assigned this Dec 23, 2024
@Valerioageno Valerioageno added the typescript Requires typescript knowledge label Dec 23, 2024
@marcalexiei marcalexiei changed the title turn zustand store into react context feat(packages/tuono-router): replace zustand with React.Context Dec 24, 2024
marcalexiei
marcalexiei requested changes Dec 24, 2024
View reviewed changes
Copy link
Member

@marcalexiei marcalexiei left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few point of discussion 😅.
If you agree with them I can take care of applying them to the PR.

packages/tuono-router/src/components/RouterContext.tsx Outdated Show resolved Hide resolved
packages/tuono-router/src/components/RouterContext.tsx Outdated Show resolved Hide resolved
packages/tuono-router/src/components/RouterContext.tsx Outdated Show resolved Hide resolved
packages/tuono-router/src/components/RouterContext.tsx Outdated Show resolved Hide resolved
packages/tuono-router/src/components/RouterContext.tsx Outdated Show resolved Hide resolved
packages/tuono-router/src/hooks/useRoute.tsx Outdated Show resolved Hide resolved
packages/tuono-router/src/components/RouterContext.tsx Outdated Show resolved Hide resolved
packages/tuono-router/src/components/RouterContext.tsx Outdated Show resolved Hide resolved
packages/tuono-router/src/components/RouterContext.tsx Outdated Show resolved Hide resolved
packages/tuono-router/src/hooks/useRouter.tsx Outdated Show resolved Hide resolved
@marcalexiei marcalexiei self-requested a review December 24, 2024 09:15
marcalexiei
marcalexiei approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@marcalexiei marcalexiei left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment regarding URLSearchParams polyfill.
Everything else looks good to me.

packages/tuono-router/src/components/RouterContext.tsx Show resolved Hide resolved
This was referenced Dec 24, 2024
Open
Closed
@Valerioageno Valerioageno merged commit d12d840 into main Dec 24, 2024
7 checks passed
@Valerioageno Valerioageno deleted the turn-zustand-store-into-a-react-context branch December 24, 2024 10:41
@marcalexiei marcalexiei mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcalexiei marcalexiei marcalexiei approved these changes

Assignees

@Valerioageno Valerioageno

Labels
typescript Requires typescript knowledge
Projects
Road to V1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request]: tuono-router - remove zustand and use React Context API
2 participants
@Valerioageno @marcalexiei