-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: add api-only
mode
#221
Conversation
e978128
to
12a2144
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove this file from VCS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove this file from VCS
@@ -0,0 +1,7 @@ | |||
# Tuono API started | |||
|
|||
This is the starter tuono project. To download it run in your terminal: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the starter tuono project. To download it run in your terminal: | |
This is the `tuono-api` starter project. | |
To download it run in your terminal: |
Probably we should update also the other examples accordingly 😅
path = ".tuono/main.rs" | ||
|
||
[dependencies] | ||
tuono_lib = { path = "../../crates/tuono_lib/", features = ["api"]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the description you speak about api-only
mode,
however the feature flag is just named api
.
Furthermore, always in the PR description, is stated:
By just adding the api feature flag to tuono_lib the CLI automatically switches to the api-only mode, entirely stripping out the SSR from the project.
So, how about using api-only
also as feature flag name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.tuono
folder is present in the .gitignore
, however files within this folder are added to version control.
Probably they were added before .gitignore
was created in this folder.
We should remove them.
Closing now since descoped |
Context & Description
This is the POC for adding the
api-only
mode to thetuono
projects.By just adding the
api
feature flag totuono_lib
the CLI automatically switches to theapi-only
mode, entirely stripping out the SSR from the project.All the declared routes are defined like the APIs defined in the
api/
folder: