-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update watchexec to v5 and watchexec-signals to v4 #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please check that the fixes work on the repositories example projects and documentation website?
crates/tuono/src/watch.rs
Outdated
use watchexec_supervisor::job::{start_job, Job}; | ||
use watchexec_supervisor::Signal; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? Technically, watchexec_supervisor::Signal
is just a re-export from watchexec_signals::Signal
https://docs.rs/watchexec-supervisor/latest/watchexec_supervisor/index.html#reexports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right - what happened was I updated watchexec
to 5.0.0 first (while watchexec_signals
was still on 3.0.0) and encountered the error mentioned in the PR description. Changing the import to watchexec_supervisor::Signal
fixed it. But updating watchexec_signals
to 4.0.0 fixes the error as well since watchexec
5.0.0 is dependent on it.
I'll revert the import back to watchexec_signals::Signal
in a later commit as it's no longer necessary
Thanks @myanvoos for addressing this! |
Related to Issue #34
Previously updating watchexec to v5 leads to this error:
This PR fixes the import issue by changing
use watchexec-signals::Signal
touse watchexec_supervisor::Signal
.It also updates watchexec-signals to v4 with no further errors.