Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES6 syntax, comments, listen for tab creation/tab moved from window, GUID for XPI loading #6

Closed
wants to merge 5 commits into from
Closed

ES6 syntax, comments, listen for tab creation/tab moved from window, GUID for XPI loading #6

wants to merge 5 commits into from

Conversation

amoore17
Copy link

@amoore17 amoore17 commented Jan 17, 2020 •
edited
Loading

Fixes

  • Now changes tab number when dragged from another window.
  • Now changes tab number when a link is opened in a new window and inserted between other tabs.
  • It is no longer possible for tab numbers not to update on a tab removal.

Additions

  • Added a randomly generated GUID so the extension can be archived to XPI and loaded in Firefox Developer Edition/Nightly. This will cause an error to appear in Chrome but not function any differently.
  • Using strict mode

Changes

  • Using ES6 syntax (arrow notation, let, const)
  • More comments to code

@amoore17 amoore17 changed the title ES6 syntax, comments, listen for tab creation, GUID for XPI loading ES6 syntax, comments, listen for tab creation/tab moved from window, GUID for XPI loading Jan 17, 2020
@amoore17 amoore17 closed this Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amoore17