Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working delta-sph and fix usage of "h_factor" #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JonasErbesdobler
Copy link
Collaborator

-implementation of delta-SPH for the current main branch
-kernel.h_factor can now be utilized

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 45.33333% with 41 lines in your changes missing coverage. Please review.

Project coverage is 65.5%. Comparing base (aa0e93a) to head (2d3b4cd).

Files Patch % Lines
jax_sph/solver.py 43.6% 40 Missing ⚠️
jax_sph/case_setup.py 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #19     +/-   ##
=======================================
- Coverage   66.4%   65.5%   -0.9%     
=======================================
  Files         11      11             
  Lines       1353    1418     +65     
=======================================
+ Hits         899     930     +31     
- Misses       454     488     +34     
Flag Coverage Δ
unittests 65.5% <45.3%> (-0.9%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants