Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publishing RGB pointclouds #146

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Publishing RGB pointclouds #146

wants to merge 2 commits into from

Conversation

alexanderkoumis
Copy link

cloud

bespoke-code
bespoke-code reviewed Jan 10, 2018
View reviewed changes
lsd_slam_core/src/main_on_images.cpp
@@ -234,14 +237,17 @@ int main( int argc, char** argv )
continue;
}
assert(imageDist.type() == CV_8U);
assert(imageDist.type() == CV_8UC3);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this line check imageDistRGB's type instead?

@bespoke-code bespoke-code mentioned this pull request Apr 8, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bespoke-code bespoke-code bespoke-code left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexanderkoumis @bespoke-code