Avatar fallback support phone numbers

[zachatrocity]

I noticed that the avatars use a fallback character if an avatar isn't set but when this is a phone number it can lead to off centered characters or random digits:

Fixed this to replace likely phone numbers with #:

Didn't see a contribution guide so let me know if this isn't cool

[sumnerevans]

Numbers are also often formatted with a - and spaces like: +1 (800) 123-4567

[zachatrocity]

Correct me if I'm wrong but we're only needing to check the first character as that's what the fallback returns

[sumnerevans]

🤔 I see, didn't quite understand the code there... I think we should be checking to make sure that the entire displayname is a phone number before using the fallback

[Glandos]

It seems that with the current code, a nickname starting with any number like 1and1 will have # has fallback character.

[zachatrocity]

Can be tricky with one time pass codes that might come from numbers like 23423 and such. Happy to do a regex on the full from param, however I noticed the comment around unicode handling and didn't want to undo that logic.

I guess a potential problem here is that if a user's name actually starts with a number then it could be rendered as # in the avatar. Today though the user 1and1 would be rendered as 1. Though keep in mind real users are more likely to set an avatar and this fallback would not be used.

How does this regex look?

https://regexr.com/8dcp6

[zachatrocity]

Logic could be something like:

• if matches phone number regex
  • return #
• else do existing fallback logic

With this flow 1and1 would return 1 if they didn't have an avatar set

[zachatrocity]

Here's the test cases I ran against. Cleaned it up and moved to utils!