Update mautrix #458
Closed
Update mautrix #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and make this a distinct commit.
…. Probably cursed.
…ct that roomData didn't used to be a pointer, I guess)
…ground contexts with the same.
tulir
reviewed
May 5, 2024
ui/commands.go
Outdated
Comment on lines
370
to
371
| ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second) | ||
| defer cancel() |
There was a problem hiding this comment.
This doesn't seem like the right place to have timeouts
ui/room-view.go
Outdated
| @@ -754,7 +760,7 @@ func (view *RoomView) SendReaction(eventID id.EventID, reaction string) { | |||
| if !view.config.Preferences.DisableEmojis { | |||
| reaction = emoji.Sprint(reaction) | |||
| } | |||
| reaction = variationselector.Add(strings.TrimSpace(reaction)) | |||
| reaction = strings.TrimSpace(reaction) | |||
There was a problem hiding this comment.
Why was this removed? Variation selectors are required
matrix/sync.go
Outdated
| listeners, exists := s.listeners[evt.Type] | ||
| if !exists { | ||
| return | ||
| } | ||
| for _, fn := range listeners { | ||
| fn(source, evt) | ||
| fn(nil, evt) |
There was a problem hiding this comment.
Passing explicit nils to a listener sounds wrong
matrix/sync.go
Outdated
Comment on lines
125
to
126
| ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second) | ||
| defer cancel() |
matrix/rooms/room.go
Outdated
| //TODO: symys changed the following to == nil, it was != nil | ||
| //requesting review, since this fixed the bug where random rooms showed up under historical, | ||
| //but idk if it might have unintended consequences | ||
| } else if room.SessionMember == nil && room.SessionMember.Membership != event.MembershipJoin { |
There was a problem hiding this comment.
This looks like a nil pointer dereference
matrix/sync.go
Outdated
| @@ -204,13 +224,13 @@ func (s *GomuksSyncer) OnSync(callback mautrix.SyncHandler) { | |||
| s.globalListeners = append(s.globalListeners, callback) | |||
| } | |||
|
|
|||
| func (s *GomuksSyncer) notifyListeners(source mautrix.EventSource, evt *event.Event) { | |||
| func (s *GomuksSyncer) notifyListeners(source event.Source, evt *event.Event) { | |||
There was a problem hiding this comment.
In general the event source doesn't need to be passed to handlers anymore as it can be embedded in the event, but contexts should be used
|
I don't get how you test this, it is not compiling at all on my end: It seems you didn't update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all the dependencies to their most recent versions, and then made the necessary changes for the client to run stably. Newly-introduced bugs may be expected at this moment.