feat: improve perf of groupMessagesForPartition (~600x in production use-case) #1576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the result of diagnosing high cpu usage on our ECS cluster.
It rewrites the
src/producer/groupMessagesPerPartition.js
implementation to be O(n)In practice, this results in a significant performance improvement.
In our use-case, we regularly have blocks of many thousands of messages (20k was the scenario that led to this diagnostic).
I'll lead with the goods:
The following runs execute groupMessagesPerPartition with the specified number of messages.
The tests were run on an ECS Fargate instance with 2vCPU allocated.