Improve enviroment setup and install instructions #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HaHeho <[email protected]>
Signed-off-by: HaHeho <[email protected]>
Signed-off-by: HaHeho <[email protected]>
Signed-off-by: HaHeho <[email protected]>
Open
Signed-off-by: HaHeho <[email protected]>
|
The solution with the ZIP archives and the example files is very clunky, although I've put instructions on combining and extracting the files easily. To do this appropriately, the large data files should probably be handled via |
(remove the redundant/contradictory version string here and parse it from `setup.py` instead) Signed-off-by: HaHeho <[email protected]>
(before "DEBUG" messages not being printed) Signed-off-by: HaHeho <[email protected]>
Signed-off-by: HaHeho <[email protected]>
Signed-off-by: HaHeho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
environment.ymlhad strictly specified package versions, which I could not set up on my system. I suppose this was done for an experiment. However, it is not helpful for people wanting to install and play around with the package.I have simplified the minimum required packages, which should yield a functioning Python environment with a single setup call in the terminal. I have updated
setup.pyand the install instructions accordingly.