You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When 2 entity objects inherit 1 base object which contains a navigation property, the SingleOrDefault() call in NavigationFindingExpressionVisitor finds many matches.
The fix also searches the descriptor type in addition to the descriptor's member.
Thank you! I paused to think about this for a few minutes. It seems there are three places in the code that use SingleOrDefault to find a navigation descriptor by comparing member equality. Additionally, the check should be against node.Expression.Type rather than node.Type, because Type on the navigation descriptor refers to the type exposing the navigation.
Glad I could help!
I had a completely different issue that I couldn't fix in order to use this with my code. The existing EF Core translator sucks performance wise when things get complicated, and I was exploring seeing if this would work on our large solution with many complex nested queries / navigations.
I'll see if I can research it more and post as an issue
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When 2 entity objects inherit 1 base object which contains a navigation property, the
SingleOrDefault()call inNavigationFindingExpressionVisitorfinds many matches.The fix also searches the descriptor type in addition to the descriptor's member.