Add hair roi to people_recognition #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthijsBurgh
requested changes
May 22, 2024
Comment on lines
227
to
230
| Convert shirt colors array to label string | ||
|
|
||
| :param: shirt_colors: Array to colors | ||
| :return: string label |
There was a problem hiding this comment.
And I see some significant overlap with _shirt_colors_to_label, so maybe reused some code instead of copying
There was a problem hiding this comment.
I wonder if it is allowed to add another parameter "hair_colors" in Person2D for genpy.message.
There was a problem hiding this comment.
No multiple colors. Currently Person2D has the parameter tshirt color and for the hair color we need to add another parameter?
There was a problem hiding this comment.
Yes, it is a different property. So we would need to extend the msg for that.
GustavoDCC
force-pushed
the
receptionist_hair_color
branch
from
4de9c07 to
a2bb487
Compare
| hair_roi.height = max(int(face_roi.height/6), 5) | ||
| hair_roi.width = max(face_roi.width, 5) | ||
| hair_roi.y_offset = min(hair_roi.y_offset, image_shape[0] - hair_roi.height) | ||
| rospy.logdebug("face_roi: {}, hair_roi: {}, img.shape: {}".format(face_roi, hair_roi, image_shape)) |
There was a problem hiding this comment.
Suggested change
| rospy.logdebug("face_roi: {}, hair_roi: {}, img.shape: {}".format(face_roi, hair_roi, image_shape)) | |
| rospy.logdebug(f"{face_roi=}, {hair_roi=}, {image_shape=}") |
MatthijsBurgh
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add the ROI for the hair to proceed with the color extraction.