Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Face recognition initial PR #221

Merged
merged 6 commits into from
Mar 12, 2024
Merged

Face recognition initial PR #221

merged 6 commits into from
Mar 12, 2024

Conversation

iasonth95
Copy link
Contributor

This is the new pkg of face recognition using openface neural network for face detection and recognition.
This is an initial PR checking.

@MatthijsBurgh
Copy link
Member

I updated this branch. I renamed the the package to include the image_recognition prefix. Your recent changes apply to the pkg with prefix. So please reset this branch to 65d24ed and cherry-pick 6c99318 on top of that. The other merge commits shouldn't be necessary.

@iasonth95
Copy link
Contributor Author

will do that today

@MatthijsBurgh
Copy link
Member

Can you remove as possible unnecessary files/code/text etc. Once this is as clean as possible, doesn't need to work yet. We can at least merge some stuff to master. And then work on the implementation. Which we have the first version of on the other branch.

@MatthijsBurgh
Copy link
Member

Merging this one, so there is something on master. And we can develop.

@MatthijsBurgh MatthijsBurgh marked this pull request as ready for review March 12, 2024 06:28
@MatthijsBurgh MatthijsBurgh merged commit 283c302 into master Mar 12, 2024
5 of 7 checks passed
@MatthijsBurgh MatthijsBurgh deleted the face_recognition branch March 12, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants