Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined theme variable #229

Merged
merged 1 commit into from
May 29, 2020
Merged

fix: undefined theme variable #229

merged 1 commit into from
May 29, 2020

Conversation

matheus1lva
Copy link
Contributor

fix #221 #228

@walkerdb
Copy link

walkerdb commented May 4, 2020

cc @tuchk4 -- this fixes an issue a lot of users are seeing on latest storybook

@matheus1lva
Copy link
Contributor Author

@walkerdb i've published fixing this under my repository. https://www.npmjs.com/package/storybook-readme-addon

i'll be maintaining that as we need fixes!

@tuchk4 tuchk4 merged commit 661face into tuchk4:master May 29, 2020
@tuchk4
Copy link
Owner

tuchk4 commented May 29, 2020

Sorry, for the super late merge :(

going to release a new version with the fix later today

@normancroan
Copy link

thanks @tuchk4 - a release today would be awesome!

@tylerlaws0n
Copy link

Did this get released? If yes, which version? I am running into the related issue with v5.0.8

@tuchk4
Copy link
Owner

tuchk4 commented Nov 16, 2020

I thought it was released half-year ago...
Released it now.

I am still surprised that somebody uses storybook-readme since most of the features are available now out from the box

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme error when using Storybook 5.3+
5 participants