Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

後世のためのメモ。 くっそ遅くなるけどRateLimit #1445

Closed
wants to merge 1 commit into from

Conversation

tubone24
Copy link
Owner

PR title

Status

READY/IN DEVELOPMENT/HOLD

Description

A few sentences describing the overall goals of the pull request's commits.

Related PRs

List related PRs against other branches:

branch PR
other_pr_master link
other_pr_develop link

Todos

  • Tests
  • e2e Tests
  • Storybook
  • Documentation

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

git pull --prune
git checkout <feature_branch>
yarn test

Preview Deploy

Describe the URL of the Preview Deploy.

link

Impacted Areas in Application

List general components of the application that this PR will affect:

  • aaa
  • bbb

Screenshot

Replace FIXME_BRANCH_NAME, FIXME_PR_NUMBER in the URL below with this branch name and PR number.

Desktop

Width 1200px

Desktop Home

Mobile

Width 400px

mobile home

Copy link
Contributor

depcheck Result

List up libraries that are defined in dependencies and devDependencies in package.json but not used in your codes.

Unused dependencies
- @popperjs/core
- @sentry/react
- @typescript-eslint/eslint-plugin
- babel-loader
- babel-polyfill
- classnames
- flexboxgrid
- gatsby-legacy-polyfills
- gatsby-plugin-flexsearch
- gatsby-plugin-twitter
- gatsby-react-router-scroll
- html-minifier
- intersection-observer
- md5
- preact
- preact-render-to-string
- react-body-classname
- react-dom
- rimraf
- sass
- typescript
Unused devdependencies
- @babel/core
- @babel/eslint-parser
- @babel/plugin-syntax-typescript
- @babel/preset-typescript
- @storybook/addon-a11y
- @storybook/addon-controls
- @storybook/addon-essentials
- @storybook/addon-info
- @storybook/addon-interactions
- @storybook/addon-knobs
- @storybook/addon-links
- @storybook/addon-storysource
- @storybook/addon-viewport
- @storybook/builder-webpack5
- @storybook/manager-webpack5
- @textlint-rule/textlint-rule-no-duplicate-abbr
- @types/jest
- @types/react-test-renderer
- @types/responselike
- axe-core
- babel-plugin-transform-runtime
- core-js
- cross-env
- css-loader
- eslint
- eslint-config-airbnb
- eslint-import-resolver-webpack
- eslint-plugin-import
- eslint-plugin-jsx-a11y
- eslint-plugin-react
- gh-pages
- husky
- identity-obj-proxy
- jest
- jest-environment-jsdom
- markdownlint-cli2
- memlab
- netlify-cli
- netlify-lambda
- nyc
- prettier
- react-test-renderer
- sass-loader
- start-server-and-test
- stylelint
- stylelint-config-recess-order
- stylelint-config-recommended-scss
- stylelint-config-standard
- stylelint-scss
- textlint
- textlint-filter-rule-allowlist
- textlint-filter-rule-comments
- textlint-rule-aws-spellcheck
- textlint-rule-ja-no-inappropriate-words
- textlint-rule-no-mixed-zenkaku-and-hankaku-alphabet
- textlint-rule-no-start-duplicated-conjunction
- textlint-rule-preset-smarthr
- textlint-rule-prh
- textlint-rule-terminology
- ts-jest
- yaml-lint
Missing
- colors
  - /github/workspace/src/styles/_hover.scss

- @algolia/transporter
  - /github/workspace/src/components/SearchBox/index.tsx

- @algolia/client-search
  - /github/workspace/src/components/SearchBox/index.tsx

- qs
  - /github/workspace/scripts/benchmark.js

- https
  - /github/workspace/scripts/uploadScreenShot.ts

- sharp
  - /github/workspace/functions/src/ogp.js

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8308057108

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.64%

Totals Coverage Status
Change from base Build 8307755245: 0.0%
Covered Lines: 251
Relevant Lines: 281

💛 - Coveralls

github-actions bot pushed a commit that referenced this pull request Mar 16, 2024
Copy link
Contributor

Deploy Preview

Deploy path: /home/runner/work/blog/blog/public
Functions path: /home/runner/work/blog/blog/functions/src
Configuration path: /home/runner/work/blog/blog/netlify.toml
Deploying to draft URL...

Netlify Build
────────────────────────────────────────────────────────────────

❯ Version
@netlify/build 29.36.1

❯ Flags
auth: TTs786GkKycSkoas9uwxVwTtamK0txQzpvHwXleU3OQ
deployId: 65f59c63c26572ae15aa21fe
dir: ./public
functions: ./functions/src
open: false
prod: false
prodIfUnlocked: false
site: 3751ef40-b145-4249-9657-39d3fb04ae81
skipFunctionsCache: false

❯ Current directory
/home/runner/work/blog/blog

❯ Config file
/home/runner/work/blog/blog/netlify.toml

❯ Context
dev

Build logs: https://app.netlify.com/sites/pensive-lamport-5822d2/deploys/65f59c63c26572ae15aa21fe
Function logs: https://app.netlify.com/sites/pensive-lamport-5822d2/functions?scope=deploy:65f59c63c26572ae15aa21fe
Website draft URL: https://65f59c63c26572ae15aa21fe--pensive-lamport-5822d2.netlify.app

If everything looks good on your draft URL, deploy it to your main site URL with the --prod flag.
netlify deploy --prod

Copy link
Contributor

Storybook Preview

Deploy path: /home/runner/work/blog/blog/storybook-static
Functions path: /home/runner/work/blog/blog/functions/src
Configuration path: /home/runner/work/blog/blog/netlify.toml
Deploying to draft URL...

Netlify Build
────────────────────────────────────────────────────────────────

❯ Version
@netlify/build 29.36.1

❯ Flags
auth: EPJJ6iiVJKf1WzATp10YTzbujNbkSqWDiVl-3kCXA-Y
deployId: 65f59ca20252f1b6223de585
dir: ./storybook-static
open: false
prod: false
prodIfUnlocked: false
site: 905285ac-8339-48d2-86d8-8d639370a095
skipFunctionsCache: false

❯ Current directory
/home/runner/work/blog/blog

❯ Config file
/home/runner/work/blog/blog/netlify.toml

❯ Context
dev

Build logs: https://app.netlify.com/sites/blog-storybook/deploys/65f59ca20252f1b6223de585
Function logs: https://app.netlify.com/sites/blog-storybook/functions?scope=deploy:65f59ca20252f1b6223de585
Website draft URL: https://65f59ca20252f1b6223de585--blog-storybook.netlify.app

If everything looks good on your draft URL, deploy it to your main site URL with the --prod flag.
netlify deploy --prod

Copy link
Contributor

Copy link
Contributor

Memlab leaks report

page-load [7.2MB] (baseline) [s1] > action-on-page [8.1MB] (target) [s2] > revert [9.2MB] (final) [s3]  
------2 clusters------

--Similar leaks in this run: 1634--
--Retained size of leaked objects: 175.8KB--
[<synthetic>] (synthetic) @1 [10.4MB]
  --3 (shortcut)--->  [Window / https://blog.tubone-project24.xyz] (object) @6269 [63.5KB]
  --setTimeout (property)--->  [<closure>] (closure) @102495 [72 bytes]
  --context (internal)--->  [<function scope>] (object) @131617 [20 bytes]
  --previous (internal)--->  [<function scope>] (object) @48721 [30.2KB]
  --n (variable)--->  [t] (closure) @130615 [1.3KB]
  --context (internal)--->  [<function scope>] (object) @82039 [42.5KB]
  --n (variable)--->  [Object] (object) @137935 [42.4KB]
  --9077 (element)--->  [Object] (object) @103687 [24 bytes]
  --exports (property)--->  [r] (closure) @103693 [2.7KB]
  --hasData (property)--->  [<closure>] (closure) @104855 [80 bytes]
  --context (internal)--->  [<function scope>] (object) @170105 [1.5KB]
  --e (variable)--->  [Object] (object) @290209 [1KB]
  --2 (element)--->  [Object] (object) @331425 [76 bytes]
  --aaAutocomplete (property)--->  [d] (object) @373387 [348 bytes]
  --$node (property)--->  [$] (object) @373731 [188 bytes]
  --0 (element)--->  [Detached HTMLSpanElement] (native) @326741 [676 bytes]
  --7 (element)--->  [Detached HTMLDivElement] (native) @326523 [5.6KB]
  --8 (element)--->  [Detached HTMLDivElement] (native) @326353 [444 bytes]
  --5 (element)--->  [Detached HTMLHRElement] (native) @326351 [356 bytes]
  --6 (element)--->  [Detached HTMLDivElement] (native) @326349 [5.2KB]
  --6 (element)--->  [Detached HTMLAnchorElement] (native) @326287 [1.9KB]
  --11 (element)--->  [Detached HTMLAnchorElement] (native) @326299 [1.9KB]
  --13 (element)--->  [Detached InternalNode] (native) @40456 [312 bytes]
  --1 (element)--->  [Detached InternalNode] (native) @43304 [256 bytes]
  --4 (element)--->  [Detached ElementIntersectionObserverData] (native) @31844 [72 bytes]

--Similar leaks in this run: 479--
--Retained size of leaked objects: 50KB--
[<synthetic>] (synthetic) @1 [10.4MB]
  --3 (shortcut)--->  [Window / https://blog.tubone-project24.xyz] (object) @6269 [63.5KB]
  --___replace (property)--->  [<closure>] (closure) @113481 [76 bytes]
  --context (internal)--->  [<function scope>] (object) @139577 [724 bytes]
  --i (variable)--->  [Module] (object) @104191 [6.3KB]
  --get version (property)--->  [version] (closure) @84753 [80 bytes]
  --context (internal)--->  [<function scope>] (object) @84767 [6.5KB]
  --Qn (variable)--->  [y] (object) @397021 [368 bytes]
  --props (property)--->  [Object] (object) @403041 [28 bytes]
  --children (property)--->  [Object] (object) @403113 [296 bytes]
  --props (property)--->  [Object] (object) @405395 [56 bytes]
  --children (property)--->  [Object] (object) @406005 [1.2KB]
  --__ (property)--->  [Object] (object) @456159 [1.1KB]
  --__ (property)--->  [Object] (object) @456171 [940 bytes]
  --__ (property)--->  [Object] (object) @456185 [736 bytes]
  --__d (property)--->  [Detached HTMLDivElement] (native) @326451 [468 bytes]
  --5 (element)--->  [Detached HTMLDivElement] (native) @326449 [384 bytes]
  --5 (element)--->  [Detached HTMLDivElement] (native) @326447 [384 bytes]
  --6 (element)--->  [Detached HTMLDivElement] (native) @326783 [14.9KB]
  --6 (element)--->  [Detached HTMLAnchorElement] (native) @326749 [2KB]
  --11 (element)--->  [Detached HTMLAnchorElement] (native) @326757 [2.2KB]
  --11 (element)--->  [Detached HTMLAnchorElement] (native) @326763 [2.9KB]
  --8 (element)--->  [Detached HTMLImageElement] (native) @326759 [852 bytes]
  --7 (element)--->  [Detached InternalNode] (native) @39664 [504 bytes]
  --1 (element)--->  [Detached InternalNode] (native) @30200 [448 bytes]
  --3 (element)--->  [Detached InternalNode] (native) @30206 [352 bytes]
  --1 (element)--->  [Detached InternalNode] (native) @36358 [352 bytes]
  --3 (element)--->  [Detached Attr] (native) @36360 [88 bytes]

github-actions bot pushed a commit that referenced this pull request Mar 16, 2024
github-actions bot pushed a commit that referenced this pull request Mar 16, 2024
github-actions bot pushed a commit that referenced this pull request Mar 16, 2024
github-actions bot pushed a commit that referenced this pull request Mar 16, 2024
Copy link
Contributor

Lighthouse Score

Desktop

performance: 76
accessibility: 100
best-practices: 100
seo: 92
pwa: 100

Mobile

performance: 82
accessibility: 100
best-practices: 96
seo: 93
pwa: 100

@tubone24 tubone24 closed this Mar 16, 2024
@tubone24 tubone24 deleted the ratelimit branch March 16, 2024 13:25
@tubone24 tubone24 changed the title fix 後世のためのメモ。 くっそ遅くなるけどRateLimit Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants