Update dependency follow-redirects to v1.15.6 [SECURITY] #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
depcheck ResultList up libraries that are defined in dependencies and devDependencies in package.json but not used in your codes. Unused dependenciesUnused devdependenciesMissing |
Pull Request Test Coverage Report for Build 8308144353Details
💛 - Coveralls |
Memlab leaks report |
Deploy PreviewDeploy path: /home/runner/work/blog/blog/public Build logs: https://app.netlify.com/sites/pensive-lamport-5822d2/deploys/65f488670df21d04c8ec2ff8 If everything looks good on your draft URL, deploy it to your main site URL with the --prod flag. |
Storybook PreviewDeploy path: /home/runner/work/blog/blog/storybook-static Build logs: https://app.netlify.com/sites/blog-storybook/deploys/65f488ac5630940632721bb9 If everything looks good on your draft URL, deploy it to your main site URL with the --prod flag. |
renovate
bot
force-pushed
the
renovate-npm-follow-redirects-vulnerability
branch
from
6790e09
to
21ab41e
Compare
Lighthouse ScoreDesktopperformance: 93 Mobileperformance: 74 |
depcheck ResultList up libraries that are defined in dependencies and devDependencies in package.json but not used in your codes. Unused dependenciesUnused devdependenciesMissing |
renovate
bot
force-pushed
the
renovate-npm-follow-redirects-vulnerability
branch
from
21ab41e
to
a5526da
Compare
depcheck ResultList up libraries that are defined in dependencies and devDependencies in package.json but not used in your codes. Unused dependenciesUnused devdependenciesMissing |
renovate
bot
force-pushed
the
renovate-npm-follow-redirects-vulnerability
branch
from
a5526da
to
27fc13e
Compare
depcheck ResultList up libraries that are defined in dependencies and devDependencies in package.json but not used in your codes. Unused dependenciesUnused devdependenciesMissing |
renovate
bot
force-pushed
the
renovate-npm-follow-redirects-vulnerability
branch
from
27fc13e
to
bfc72ad
Compare
depcheck ResultList up libraries that are defined in dependencies and devDependencies in package.json but not used in your codes. Unused dependenciesUnused devdependenciesMissing |
Memlab leaks report |
Lighthouse ScoreDesktopperformance: 85 Mobileperformance: 76 |
renovate
bot
force-pushed
the
renovate-npm-follow-redirects-vulnerability
branch
from
f0a9b35
to
a7c0665
Compare
depcheck ResultList up libraries that are defined in dependencies and devDependencies in package.json but not used in your codes. Unused dependenciesUnused devdependenciesMissing |
Memlab leaks report |
Deploy PreviewDeploy path: /home/runner/work/blog/blog/public Build logs: https://app.netlify.com/sites/pensive-lamport-5822d2/deploys/65f5a206fbe72cb7c152f3dd If everything looks good on your draft URL, deploy it to your main site URL with the --prod flag. |
Storybook PreviewDeploy path: /home/runner/work/blog/blog/storybook-static Build logs: https://app.netlify.com/sites/blog-storybook/deploys/65f5a21e563094b9b9721cef If everything looks good on your draft URL, deploy it to your main site URL with the --prod flag. |
Lighthouse ScoreDesktopperformance: 98 Mobileperformance: 76 |
tubone24
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.15.5->1.15.6GitHub Vulnerability Alerts
CVE-2024-28849
When using axios, its dependency library follow-redirects only clears authorization header during cross-domain redirect, but allows the proxy-authentication header which contains credentials too.
Steps To Reproduce & PoC
axios Test Code
const axios = require('axios');
axios.get('http://127.0.0.1:10081/',{
headers: {
'AuThorization': 'Rear Test',
'ProXy-AuthoriZation': 'Rear Test',
'coOkie': 't=1'
}
}).then(function (response) {
console.log(response);
})
When I meet the cross-domain redirect, the sensitive headers like authorization and cookie are cleared, but proxy-authentication header is kept.
Request sent by axios
image-20240314130755052.png
Request sent by follow-redirects after redirectimage-20240314130809838.png
Impact
This vulnerability may lead to credentials leak.
Recommendations
Remove proxy-authentication header during cross-domain redirect
Recommended Patch
follow-redirects/index.js:464
removeMatchingHeaders(/^(?:authorization|cookie)$/i, this._options.headers);
change to
removeMatchingHeaders(/^(?:authorization|proxy-authorization|cookie)$/i, this._options.headers);
Ref
https://fetch.spec.whatwg.org/#authentication-entries
https://hackerone.com/reports/2390009
Release Notes
follow-redirects/follow-redirects (follow-redirects)
v1.15.6Compare Source
Configuration
📅 Schedule: Branch creation - "" in timezone Asia/Tokyo, Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.