attack: early cancel ctx only when there's no err

This fixes a bug introduced in 074c530 where we'd be cancelling the racing go-routines even when the first one produced an error, hence returning an error. Signed-off-by: Tomás Senart <[email protected]>
tsenart · Jul 24, 2023 · e49c367 · e49c367
1 parent 3fd94ee
commit e49c367
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/attack.go b/lib/attack.go
@@ -356,7 +356,9 @@ func DNSCaching(ttl time.Duration) func(*Attacker) {
 				for _, ip := range ips {
 					go func(ip string) {
 						conn, err := dial(ctx, network, net.JoinHostPort(ip, port))
-						cancel()
+						if err == nil {
+							cancel()
+						}
 						ch <- result{conn, err}
 					}(ip)
 				}