Fix #247, Don't remove straw nodes that are dead ends, create edges between straws with same parent capacity mesh node #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
don't mind the commits before fb72737. those are from a previous branch that i branched off from. |
seveibar
reviewed
Sep 21, 2025
seveibar
changed the title
|
@Heinrich-XIAO i've examined an increase the the time for the keyboard solver from 11.3s to ~14s (+20% duration) 
I understand what's happening now but this is probably not the right solution. Straws nodes should not travel to eachother. Video to follow |
|
Video analysis on discord: https://discord.com/channels/1233487248129921135/1419378300073017534/1419378649311739984 |
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #247 by connecting straws in edge solver.
/claim #247