Align close same-net trace segments during cleanup by justusaugust · Pull Request #429 · tscircuit/schematic-trace-solver

justusaugust · 2026-05-25T00:06:04Z

Summary

add a final TraceCleanupSolver phase that aligns nearby overlapping internal same-net horizontal/vertical segments onto a shared axis
preserve endpoint/pin legs and ignore different-net candidates
reject alignments that would introduce different-net, chip-obstacle, self-intersection, or different-net label collisions
add focused before/after-style coverage for horizontal, vertical, endpoint, different-net, obstacle, self-collision, label-collision, and collision-guard behavior

/claim #29
/claim #34

Verification

bun test tests/solvers/TraceCleanupSolver/alignNearbySameNetSegments.test.ts tests/examples/example29.test.ts tests/examples/example34.test.ts
bun test -> 72 pass, 4 skip, 0 fail
bunx tsc --noEmit
bun run format:check
bun run build
git diff --check

vercel · 2026-05-25T00:06:10Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
schematic-trace-solver	Ready	Preview, Comment	May 25, 2026 2:29pm

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0434b61817

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

justusaugust · 2026-05-25T00:12:58Z

Added an in-repo before/after SVG proof snapshot for the same-net alignment behavior at tests/solvers/TraceCleanupSolver/__snapshots__/before-after.snap.svg.

Verification after the added proof:

bun test (65 pass, 4 skip, 0 fail)
bunx tsc --noEmit
bun run format:check
bun run build
git diff --check

Remote PR checks are green after commit cd631b6.

justusaugust · 2026-05-25T00:25:54Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 98c6ad0c9c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

justusaugust · 2026-05-25T00:34:11Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 81ea845878

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

justusaugust · 2026-05-25T00:50:55Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ed89eb6765

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

justusaugust · 2026-05-25T01:03:24Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2e8e61ef71

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fix: align close same-net trace segments

0434b61

algora-pbc Bot added the 🙋 Bounty claim label May 25, 2026

algora-pbc Bot mentioned this pull request May 25, 2026

New Phase To combine same-net trace segments that are close together #29

Open

vercel Bot deployed to Preview May 25, 2026 00:06 View deployment

chatgpt-codex-connector Bot reviewed May 25, 2026

View reviewed changes

Comment thread lib/solvers/TraceCleanupSolver/alignNearbySameNetSegments.ts Outdated

test: add same-net alignment proof snapshot

cd631b6

vercel Bot deployed to Preview May 25, 2026 00:12 View deployment

fix: avoid chip collisions during trace alignment

98c6ad0

vercel Bot deployed to Preview May 25, 2026 00:18 View deployment

justusaugust mentioned this pull request May 25, 2026

Merge same-net trace lines that are close together (make at the same Y or same X) #34

Open

chatgpt-codex-connector Bot reviewed May 25, 2026

View reviewed changes

Comment thread lib/solvers/TraceCleanupSolver/alignNearbySameNetSegments.ts Outdated

fix: allow preexisting alignment collisions

81ea845

vercel Bot deployed to Preview May 25, 2026 00:33 View deployment

chatgpt-codex-connector Bot reviewed May 25, 2026

View reviewed changes

Comment thread lib/solvers/TraceCleanupSolver/alignNearbySameNetSegments.ts Outdated

Comment thread lib/solvers/TraceCleanupSolver/alignNearbySameNetSegments.ts Outdated

fix: compare alignment collision footprints

ed89eb6

vercel Bot deployed to Preview May 25, 2026 00:50 View deployment

chatgpt-codex-connector Bot reviewed May 25, 2026

View reviewed changes

Comment thread lib/solvers/TraceCleanupSolver/alignNearbySameNetSegments.ts

fix: reject self-intersecting alignments

2e8e61e

vercel Bot deployed to Preview May 25, 2026 01:03 View deployment

chatgpt-codex-connector Bot reviewed May 25, 2026

View reviewed changes

Comment thread lib/solvers/TraceCleanupSolver/TraceCleanupSolver.ts

fix: preserve label clearance during trace alignment

007258e

vercel Bot deployed to Preview May 25, 2026 14:29 View deployment

Conversation

justusaugust commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Uh oh!

vercel Bot commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

justusaugust commented May 25, 2026

Uh oh!

justusaugust commented May 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

justusaugust commented May 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

justusaugust commented May 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

justusaugust commented May 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

justusaugust commented May 25, 2026 •

edited

Loading

vercel Bot commented May 25, 2026 •

edited

Loading