Add same-net trace consolidation phase#411
Open
ColumbusLabs wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
a474a9a to
2a10697
Compare
Author
|
Rebased onto latest |
Author
|
Updated the PR body to include the #34 claim and added a traceability comment on issue #34: #34 (comment) The PR is rebased and mergeable. Vercel is green. The repository GitHub Actions suites for Bun Test, Format Check, and Type Check are currently
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SameNetTraceConsolidationSolverpipeline phase after trace cleanup and before final label placement.Fixes #29.
Addresses #34 by aligning close same-net segments onto a shared X/Y coordinate.
Why this approach
This keeps the behavior in a standalone solver phase, matching #29's request for a new pipeline phase rather than folding the logic into unrelated cleanup code. The phase is intentionally conservative: it groups only same-net orthogonal segments, uses deterministic ordering, preserves endpoint anchors, and refuses changes that make collisions worse.
Coverage
example38after rebasing around upstream's newly mergedexample37.Verification
bun test tests/solvers/SameNetTraceConsolidationSolver/SameNetTraceConsolidationSolver.test.ts tests/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver_sameNetTraceConsolidationPhase.test.ts tests/examples/example38.test.ts-> 13 pass, 0 failbun test-> 73 pass, 4 skip, 0 failbun run format:check-> passbun run build-> passgit diff --check-> passNote: GitHub Actions check suites for this fork currently show
action_required/awaiting maintainer approval, so the repository's Bun Test, Format Check, and Type Check workflows are not visible on the PR yet. I ran their local equivalents above; Vercel is green./claim #29
/claim #34