add oval hole support#2393
Open
rushabhcodes wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ovalhandling to theHoleprimitive so it emits apcb_holewithhole_shape: "oval"<hole shape="oval" />Why
@tscircuit/propsalready acceptsshape="oval", and nearby code paths already understand oval holes, butlib/components/primitive-components/Hole.tsstill fell through to the circular-hole branch. That meant oval holes were not emitted correctly from the primitive component itself.Validation
bunx tsc --noEmitbun test tests/components/primitive-components/hole-oval.test.tsxbun test tests/components/primitive-components/hole.test.tsxbun test tests/components/primitive-components/hole-pill.test.tsxbun test tests/components/primitive-components/hole-rect.test.tsx