Skip to content

add oval hole support#2393

Open
rushabhcodes wants to merge 2 commits into
tscircuit:mainfrom
rushabhcodes:codex/add-oval-hole-support
Open

add oval hole support#2393
rushabhcodes wants to merge 2 commits into
tscircuit:mainfrom
rushabhcodes:codex/add-oval-hole-support

Conversation

@rushabhcodes
Copy link
Copy Markdown
Contributor

Summary

  • add oval handling to the Hole primitive so it emits a pcb_hole with hole_shape: "oval"
  • treat oval holes like other width/height hole shapes when computing PCB bounds
  • add a focused regression test and PCB snapshot for <hole shape="oval" />

Why

@tscircuit/props already accepts shape="oval", and nearby code paths already understand oval holes, but lib/components/primitive-components/Hole.ts still fell through to the circular-hole branch. That meant oval holes were not emitted correctly from the primitive component itself.

Validation

  • bunx tsc --noEmit
  • bun test tests/components/primitive-components/hole-oval.test.tsx
  • bun test tests/components/primitive-components/hole.test.tsx
  • bun test tests/components/primitive-components/hole-pill.test.tsx
  • bun test tests/components/primitive-components/hole-rect.test.tsx

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview, Comment Jun 4, 2026 12:56pm

Request Review

@rushabhcodes rushabhcodes changed the title [codex] add oval hole support add oval hole support Jun 4, 2026
@rushabhcodes rushabhcodes marked this pull request as ready for review June 4, 2026 12:58
Copilot AI review requested due to automatic review settings June 4, 2026 12:58
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants