Add pill shape for the pcb_hole

src/pcb/pcb_hole.ts

@@ -45,29 +45,29 @@ const pcb_hole_oval = z.object({
   pcb_hole_id: getZodPrefixedIdWithDefault("pcb_hole"),
   pcb_group_id: z.string().optional(),
   subcircuit_id: z.string().optional(),
-  hole_shape: z.literal("oval"),
+  hole_shape: z.enum(["oval", "pill"]),
   hole_width: z.number(),
   hole_height: z.number(),
   x: distance,
   y: distance,
 })
 
 export const pcb_hole_oval_shape = pcb_hole_oval.describe(
-  "Defines an oval hole on the PCB",
+  "Defines an oval or pill-shaped hole on the PCB",
 )
 
 export type PcbHoleOvalInput = z.input<typeof pcb_hole_oval>
 type InferredPcbHoleOval = z.infer<typeof pcb_hole_oval>
 
 /**
- * Defines an oval hole on the PCB
+ * Defines an oval or pill-shaped hole on the PCB
  */
 export interface PcbHoleOval {
   type: "pcb_hole"
   pcb_hole_id: string
   pcb_group_id?: string
   subcircuit_id?: string
-  hole_shape: "oval"
+  hole_shape: "oval" | "pill"
   hole_width: number
   hole_height: number
   x: Distance

tests/pcb_hole.test.ts

@@ -0,0 +1,83 @@
+import { expect, test } from "bun:test"
+import {
+  pcb_hole,
+  type PcbHoleCircleOrSquare,
+  type PcbHoleOval,
+} from "../src/pcb/pcb_hole"
+
+test("parse circle hole", () => {
+  const hole = pcb_hole.parse({
+    type: "pcb_hole",
+    hole_shape: "circle",
+    hole_diameter: 1.5,
+    x: 0,
+    y: 0,
+  }) as PcbHoleCircleOrSquare
+
+  expect(hole.hole_shape).toBe("circle")
+  expect(hole.hole_diameter).toBe(1.5)
+})
+
+test("parse square hole", () => {
+  const hole = pcb_hole.parse({
+    type: "pcb_hole",
+    hole_shape: "square",
+    hole_diameter: 2.0,
+    x: 0,
+    y: 0,
+  }) as PcbHoleCircleOrSquare
+
+  expect(hole.hole_shape).toBe("square")
+  expect(hole.hole_diameter).toBe(2.0)
+})
+
+test("parse oval hole", () => {
+  const hole = pcb_hole.parse({
+    type: "pcb_hole",
+    hole_shape: "oval",
+    hole_width: 3.0,
+    hole_height: 1.5,
+    x: 0,
+    y: 0,
+  }) as PcbHoleOval
+
+  expect(hole.hole_shape).toBe("oval")
+  expect(hole.hole_width).toBe(3.0)
+  expect(hole.hole_height).toBe(1.5)
+})
+
+test("parse pill hole", () => {
+  const hole = pcb_hole.parse({
+    type: "pcb_hole",
+    hole_shape: "pill",
+    hole_width: 2.5,
+    hole_height: 1.0,
+    x: 0,
+    y: 0,
+  }) as PcbHoleOval
+
+  expect(hole.hole_shape).toBe("pill")
+  expect(hole.hole_width).toBe(2.5)
+  expect(hole.hole_height).toBe(1.0)
+})
+
+test("parse pill hole with optional properties", () => {
+  const hole = pcb_hole.parse({
+    type: "pcb_hole",
+    hole_shape: "pill",
+    hole_width: 2.5,
+    hole_height: 1.0,
+    x: 1.5,
+    y: -1.0,
+    pcb_group_id: "group_1",
+    subcircuit_id: "subcircuit_1",
+  }) as PcbHoleOval
+
+  expect(hole.hole_shape).toBe("pill")
+  expect(hole.hole_width).toBe(2.5)
+  expect(hole.hole_height).toBe(1.0)
+  expect(hole.x).toBe(1.5)
+  expect(hole.y).toBe(-1.0)
+  expect(hole.pcb_group_id).toBe("group_1")
+  expect(hole.subcircuit_id).toBe("subcircuit_1")
+})