add support for bounds packing #49
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| let viableBounds = { | ||
| minX: largestRectBounds.minX - componentBounds.minX * segmentNormAbs.x, | ||
| minY: largestRectBounds.minY - componentBounds.minY * segmentNormAbs.y, | ||
| maxX: largestRectBounds.maxX - componentBounds.maxX * segmentNormAbs.x, | ||
| maxY: largestRectBounds.maxY - componentBounds.maxY * segmentNormAbs.y, | ||
| } | ||
|
|
||
| if (this.globalBounds) { | ||
| viableBounds = { | ||
| minX: Math.max(viableBounds.minX, this.globalBounds.minX), | ||
| minY: Math.max(viableBounds.minY, this.globalBounds.minY), | ||
| maxX: Math.min(viableBounds.maxX, this.globalBounds.maxX), | ||
| maxY: Math.min(viableBounds.maxY, this.globalBounds.maxY), |
There was a problem hiding this comment.
[P1] Intersecting with global bounds ignores component size
When global bounds are provided, viableBounds is intersected with those limits directly but without shrinking them by the component’s extents. For axes where segmentNormAbs is 0 (e.g., a vertical outline segment), the viable center range still spans the full largestRectBounds on that axis, so the resulting candidate can have its center at globalBounds.maxX or minX while the component’s body extends past the edge. If the user specifies tight board bounds, the solver will now generate placements that protrude outside the bounds even though it claims to respect them. Intersecting should subtract the component’s min/max offsets from this.globalBounds before clamping.
Useful? React with 👍 / 👎.
1 participant
No description provided.