Improve python build #245
Merged
Improve python build #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschoonj
force-pushed
the
improve-python-build
branch
from
316277e to
da353db
Compare
tschoonj
force-pushed
the
improve-python-build
branch
from
7c7b49e to
a532d54
Compare
tschoonj
force-pushed
the
improve-python-build
branch
from
a532d54 to
6a3237f
Compare
tschoonj
commented
Aug 20, 2024
| @@ -1491,7 +1492,7 @@ Q1_SHELL = xrl.Q1_SHELL | |||
| Q2_SHELL = xrl.Q2_SHELL | |||
| Q3_SHELL = xrl.Q3_SHELL | |||
|
|
|||
| def AtomicWeight(cnp.ndarray[long, ndim=1] Z not None): | |||
| def AtomicWeight(cnp.ndarray[int64_t, ndim=1] Z not None): | |||
There was a problem hiding this comment.
@t20100 I had to make a change to your patch as it didn't work properly on Windows with the numpy example:
ValueError: Buffer dtype mismatch, expected 'long' but got 'long long'
This is due to Windows treating longs as 32-bit integers instead of 64-bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements in this PR: