chore: add linter to api + types redundancy removal

apps/api-v2/.eslintrc.json

@@ -0,0 +1,13 @@
+{
+    "root": true,
+    "parser": "@typescript-eslint/parser",
+    "plugins": ["@typescript-eslint"],
+    "extends": [
+        "eslint:recommended",
+        "plugin:@typescript-eslint/recommended"
+    ],
+    "rules": {
+        // Add your custom rules here
+        "@typescript-eslint/no-explicit-any": "off"
+    }
+}

apps/api-v2/package.json

@@ -15,7 +15,8 @@
     "db:migrate": "prisma migrate deploy",
     "schema:generate": "prisma generate",
     "db:start": "docker-compose up -d",
-    "db:setup": "npm run db:start && npm run db:migrate"
+    "db:setup": "npm run db:start && npm run db:migrate",
+    "lint": "eslint --ext .ts src"
   },
   "keywords": [],
   "author": "Vincent Vu <[email protected]>",
@@ -33,6 +34,9 @@
     "@types/passport-google-oauth20": "^2.0.11",
     "@types/response-time": "^2.3.5",
     "@types/supertest": "^2.0.12",
+    "@typescript-eslint/eslint-plugin": "^6.7.4",
+    "@typescript-eslint/parser": "^6.7.4",
+    "eslint": "^8.50.0",
     "jest": "^29.6.4",
     "jest-express": "^1.12.0",
     "prisma": "^5.2.0",

apps/api-v2/src/__tests__/index.test.ts

@@ -4,7 +4,7 @@ import { Server } from "http";
 import config from "../config";
 
 let httpServer: Server;
-let { app } = createApp();
+const { app } = createApp();
 
 beforeEach(() => {
   // run the server first

apps/api-v2/src/logging.ts

@@ -2,7 +2,7 @@ import config from "./config";
 import pino from "pino";
 
 // only enable logging to axiom in production
-export let loggerOptions: any = {};
+export let loggerOptions: Record<string, any> = {};
 if (process.env.NODE_ENV === "production") {
   loggerOptions = {
     transport: {

apps/api-v2/src/routers/auth.ts

@@ -4,12 +4,11 @@ import config from "../config";
 import jwt from "jsonwebtoken";
 import {
   EncodedProfileTokenClaims,
-  IAuthCtx,
   IAuthPassportCallbackCtx,
   SupernovaResponse,
 } from "../types";
 import { authenticateJWTMiddleware } from "../mws";
-import { prisma, redis } from "../db";
+import { redis } from "../db";
 import { logger } from "../logging";
 import { Strategy as GoogleStrategy } from "passport-google-oauth20";
 import { getAuthContext } from "../utils";
@@ -143,41 +142,47 @@ export default function buildAuthRouter(): Router {
     );
   });
 
-  router.get("/auth/logout", authenticateJWTMiddleware, async (req, res) => {
-    try {
-      const userAuthCtx = getAuthContext(req);
-      // delete the refresh token from redis (stored as a KV pair of user ID -> refresh token)
-      if (userAuthCtx.sub === undefined) {
-        logger.error(
-          `userAuthCtx.sub is undefined; userAuthCtx=${JSON.stringify(
-            userAuthCtx
-          )}`
-        );
-        return res.status(400).send(
-          new SupernovaResponse({
-            error: "Internal Server Error",
-            message: "Failed to logout user",
-          })
-        );
-      }
-      await redis.connect();
-      const resdel = await redis.del(userAuthCtx.sub);
-      await redis.disconnect();
-      // didn't delete anything
-      if (resdel === 0) {
+  router.get(
+    "/auth/logout",
+    authenticateJWTMiddleware,
+    async (req, res, next) => {
+      try {
+        const userAuthCtx = getAuthContext(req);
+        // delete the refresh token from redis (stored as a KV pair of user ID -> refresh token)
+        if (userAuthCtx.sub === undefined) {
+          logger.error(
+            `userAuthCtx.sub is undefined; userAuthCtx=${JSON.stringify(
+              userAuthCtx
+            )}`
+          );
+          return res.status(400).send(
+            new SupernovaResponse({
+              error: "Internal Server Error",
+              message: "Failed to logout user",
+            })
+          );
+        }
+        await redis.connect();
+        const resdel = await redis.del(userAuthCtx.sub);
+        await redis.disconnect();
+        // didn't delete anything
+        if (resdel === 0) {
+          return res.status(200).send(
+            new SupernovaResponse({
+              message: "User has already been logged out",
+            })
+          );
+        }
         return res.status(200).send(
           new SupernovaResponse({
-            message: "User has already been logged out",
+            message: "User logged out",
           })
         );
+      } catch (err) {
+        return next(err);
       }
-      return res.status(200).send(
-        new SupernovaResponse({
-          message: "User logged out",
-        })
-      );
-    } catch (err) {}
-  });
+    }
+  );
 
   return router;
 }

apps/api-v2/src/types.ts

@@ -1,7 +1,7 @@
 import { Profile } from "passport-google-oauth20";
 import jwt from "jsonwebtoken";
 
-export interface ISupernovaResponse<T extends any> {
+export interface ISupernovaResponse<T> {
   data?: T;
   error?: string;
   message?: string;

apps/api-v2/tsconfig.json

@@ -83,7 +83,7 @@
 
     /* Type Checking */
     "strict": true,                                      /* Enable all strict type-checking options. */
-    // "noImplicitAny": true,                            /* Enable error reporting for expressions and declarations with an implied 'any' type. */
+    "noImplicitAny": true,                            /* Enable error reporting for expressions and declarations with an implied 'any' type. */
     // "strictNullChecks": true,                         /* When type checking, take into account 'null' and 'undefined'. */
     // "strictFunctionTypes": true,                      /* When assigning functions, check to ensure parameters and the return values are subtype-compatible. */
     // "strictBindCallApply": true,                      /* Check that the arguments for 'bind', 'call', and 'apply' methods match the original function. */

apps/desktop-v2/components/command-center.tsx

@@ -4,7 +4,7 @@ import Mousetrap from "mousetrap";
 import React from "react";
 import { Kbd } from "./kbd";
 import { SupernovaCommand } from "../types/command";
-import { ISupernovaTask } from "../types/supernova-task";
+import { ISupernovaTask } from "@supernova/types";
 import { twMerge } from "tailwind-merge";
 import { ibmPlexMono } from "./fonts";
 import { SupernovaGlobeLogoImage } from "./icons";

apps/desktop-v2/components/supernova-task.tsx

@@ -1,7 +1,7 @@
 "use client";
 import { ArrowRightIcon } from "./icons";
 import * as React from "react";
-import { ISupernovaTask } from "../types/supernova-task";
+import { ISupernovaTask } from "@supernova/types";
 import { CustomCheckbox } from "./checkbox";
 import { DurationWidget } from "./duration-widget";
 import { StartTimeWidget } from "./start-time-widget";

apps/desktop-v2/components/task-builder-dialog.tsx

@@ -13,7 +13,7 @@ import {
   RenderLeafProps,
 } from "slate-react";
 import { Descendant } from "slate";
-import { ISupernovaTask } from "../types/supernova-task";
+import { ISupernovaTask } from "@supernova/types";
 import {
   extractExpectedDuration,
   START_AT_SLATE_TYPE,

apps/desktop-v2/services/local-db.ts

@@ -1,5 +1,5 @@
 import Database from "tauri-plugin-sql-api";
-import { ISupernovaTask } from "../types/supernova-task";
+import { ISupernovaTask } from "@supernova/types";
 
 export namespace LocalDB {
   // delete the table supernova_tasks if it exists