adding an injectable error handler for listen() #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use retoolRPC and occasionally there are socket hang ups and other network issues that trigger the default error logging behaviour in the polling listen method.
This is fine, however it does make for some messy logging situations. The actual reason for the failure is included so we could filter on these messages. But one other way would be to allow users the ability to decide what they want to do on an error instead. This shouldn't interfere with the operation of anything out of the box or by default, but it does give the consumer of the SDK the ability to back-off at their discretion, or to just propagate a failure and exit.
I also added
package-lock.json
to the.gitignore
file because you guys use yarn.