Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding an injectable error handler for listen() #34

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

trevoro
Copy link

@trevoro trevoro commented Sep 12, 2024

We use retoolRPC and occasionally there are socket hang ups and other network issues that trigger the default error logging behaviour in the polling listen method.

This is fine, however it does make for some messy logging situations. The actual reason for the failure is included so we could filter on these messages. But one other way would be to allow users the ability to decide what they want to do on an error instead. This shouldn't interfere with the operation of anything out of the box or by default, but it does give the consumer of the SDK the ability to back-off at their discretion, or to just propagate a failure and exit.

I also added package-lock.json to the .gitignore file because you guys use yarn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant