Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #18: Adds main, module, types keys in package.json #19

Conversation

noahsark769
Copy link
Contributor

Fixes #18

This adds the appropriate main, module, and types keys to retoolrpc's javascript's package.json such that typechecking works correctly under "module": "CommonJS" and "moduleResolution": "bundler". See https://github.com/noahsark769/retoolrpc-typescript-issue and #18 for more discussion about this issue.

@huytool157 huytool157 merged commit 6c078ec into tryretool:main Mar 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript checks fail under "module": "CommonJS" and "moduleResolution": "bundler"
2 participants