Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update semverCompare target to include -0 patch #176

Merged
merged 1 commit into from
May 28, 2024

Conversation

avimoondra
Copy link
Contributor

@avimoondra avimoondra commented May 28, 2024

https://helm.sh/docs/chart_template_guide/function_list/#working-with-prerelease-versions

"-stable" and "-edge" are considered pre-release

Ran tests from

--

(stable)

helm template -f ~/retool-helm/charts/retool/values.yaml foo ~/retool-helm/charts/retool --set config.encryptionKey="foo" --set image.tag="3.33.13-stable" | rg "kind: Deployment" -C 2

# Source: retool/templates/deployment_backend.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool
--
# Source: retool/templates/deployment_code_executor.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool-code-executor
--
# Source: retool/templates/deployment_jobs.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool-jobs-runner
--
# Source: retool/templates/deployment_workflows.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool-workflow-backend
--
# Source: retool/templates/deployment_workflows_worker.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool-workflow-worker

(edge)

retool-helm git:(avimoondra/update-helm-with-path0) helm template -f ~/retool-helm/charts/retool/values.yaml foo ~/retool-helm/charts/retool --set config.encryptionKey="foo" --set image.tag="3.38.0-edge" | rg "kind: Deployment" -C 2

# Source: retool/templates/deployment_backend.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool
--
# Source: retool/templates/deployment_code_executor.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool-code-executor
--
# Source: retool/templates/deployment_jobs.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool-jobs-runner
--
# Source: retool/templates/deployment_workflows.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool-workflow-backend
--
# Source: retool/templates/deployment_workflows_worker.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool-workflow-worker

(internal image tag)

retool-helm git:(avimoondra/update-helm-with-path0) helm template -f ~/retool-helm/charts/retool/values.yaml foo ~/retool-helm/charts/retool --set config.encryptionKey="foo" --set image.tag="release-3.39.0-a0b2a86" --set codeExecutor.enabled="false" --set workflows.enabled="false" | rg "kind: Deployment" -C 2

# Source: retool/templates/deployment_backend.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool
--
# Source: retool/templates/deployment_jobs.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool-jobs-runner

(internal image tag w/workflows)

retool-helm git:(avimoondra/update-helm-with-path0) helm template -f ~/retool-helm/charts/retool/values.yaml foo ~/retool-helm/charts/retool --set config.encryptionKey="foo" --set image.tag="release-3.39.0-a0b2a86" --set codeExecutor.enabled="false" --set workflows.enabled="true" | rg "kind: Deployment" -C 2

# Source: retool/templates/deployment_backend.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool
--
# Source: retool/templates/deployment_jobs.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool-jobs-runner
--
# Source: retool/templates/deployment_workflows.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool-workflow-backend
--
# Source: retool/templates/deployment_workflows_worker.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool-workflow-worker

--

(all services, but not stable or release)

helm template -f ~/retool-helm/charts/retool/values.yaml foo ~/retool-helm/charts/retool --set config.encryptionKey="foo" --set image.tag="3.24.24" | rg "kind: Deployment" -C 2

# Source: retool/templates/deployment_backend.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool
--
# Source: retool/templates/deployment_code_executor.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool-code-executor
--
# Source: retool/templates/deployment_jobs.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool-jobs-runner
--
# Source: retool/templates/deployment_workflows.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool-workflow-backend
--
# Source: retool/templates/deployment_workflows_worker.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool-workflow-worker

(no code executor)

retool-helm git:(avimoondra/update-helm-with-path0) helm template -f ~/retool-helm/charts/retool/values.yaml foo ~/retool-helm/charts/retool --set config.encryptionKey="foo" --set image.tag="3.10.10" | rg "kind: Deployment" -C 2

# Source: retool/templates/deployment_backend.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool
--
# Source: retool/templates/deployment_jobs.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool-jobs-runner
--
# Source: retool/templates/deployment_workflows.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool-workflow-backend
--
# Source: retool/templates/deployment_workflows_worker.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool-workflow-worker

(no workflows)

retool-helm git:(avimoondra/update-helm-with-path0) helm template -f ~/retool-helm/charts/retool/values.yaml foo ~/retool-helm/charts/retool --set config.encryptionKey="foo" --set image.tag="3.4.10" | rg "kind: Deployment" -C 2

# Source: retool/templates/deployment_backend.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool
--
# Source: retool/templates/deployment_jobs.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-retool-jobs-runner

@avimoondra avimoondra merged commit 81bc3e5 into main May 28, 2024
12 checks passed
@avimoondra avimoondra deleted the avimoondra/update-helm-with-path0 branch May 28, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants