Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support 1 replica api backend with jobs runner #131

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

avimoondra
Copy link
Contributor

@avimoondra avimoondra commented Nov 19, 2023

Support 1 replica api backend with 1 jobs runner pod. Previously replicaCount of 2 was required to separate jobs runner from api backend, which resulted in 2 api backends -- forcing the overall capacity to have this separation of services across pods.

--set jobRunner.enabled=true --set replicaCount=1

$ helm template -f ~/retool-helm/charts/retool/values.yaml foo ~/retool-helm/charts/retool --set config.encryptionKey="foo" --set image.tag="5.6.10" --set jobRunner.enabled=true --set replicaCount=1  --debug | rg replicas -C 7
install.go:192: [debug] Original chart version: ""
install.go:209: [debug] CHART PATH: /Users/avimoondra/retool-helm/charts/retool

  name: foo-retool
  labels:
    helm.sh/chart: retool-6.0.7
    app.kubernetes.io/name: retool
    app.kubernetes.io/instance: foo
    app.kubernetes.io/managed-by: Helm
spec:
  replicas: 1
  selector:
    matchLabels:
      app.kubernetes.io/name: retool
      app.kubernetes.io/instance: foo
  revisionHistoryLimit: 3
  template:
    metadata:
--
  name: foo-retool-jobs-runner
  labels:
    helm.sh/chart: retool-6.0.7
    app.kubernetes.io/name: retool
    app.kubernetes.io/instance: foo
    app.kubernetes.io/managed-by: Helm
spec:
  replicas: 1
  selector:
    matchLabels:
      app.kubernetes.io/name: retool-jobs-runner
      app.kubernetes.io/instance: foo
  revisionHistoryLimit: 3
  template:
    metadata:
--

--set jobRunner.enabled=true --set replicaCount=2

$ helm template -f ~/retool-helm/charts/retool/values.yaml foo ~/retool-helm/charts/retool --set config.encryptionKey="foo" --set image.tag="5.6.10" --set jobRunner.enabled=true --set replicaCount=2  --debug  | rg replicas -C 7

install.go:192: [debug] Original chart version: ""
install.go:209: [debug] CHART PATH: /Users/avimoondra/retool-helm/charts/retool

  name: foo-retool
  labels:
    helm.sh/chart: retool-6.0.7
    app.kubernetes.io/name: retool
    app.kubernetes.io/instance: foo
    app.kubernetes.io/managed-by: Helm
spec:
  replicas: 2
  selector:
    matchLabels:
      app.kubernetes.io/name: retool
      app.kubernetes.io/instance: foo
  revisionHistoryLimit: 3
  template:
    metadata:
--
  name: foo-retool-jobs-runner
  labels:
    helm.sh/chart: retool-6.0.7
    app.kubernetes.io/name: retool
    app.kubernetes.io/instance: foo
    app.kubernetes.io/managed-by: Helm
spec:
  replicas: 1
  selector:
    matchLabels:
      app.kubernetes.io/name: retool-jobs-runner
      app.kubernetes.io/instance: foo
  revisionHistoryLimit: 3
  template:
    metadata:
--

--set replicaCount=2

$ helm template -f ~/retool-helm/charts/retool/values.yaml foo ~/retool-helm/charts/retool --set config.encryptionKey="foo" --set image.tag="5.6.10" --set replicaCount=2  --debug | rg replicas -C 7

install.go:192: [debug] Original chart version: ""
install.go:209: [debug] CHART PATH: /Users/avimoondra/retool-helm/charts/retool

  name: foo-retool
  labels:
    helm.sh/chart: retool-6.0.7
    app.kubernetes.io/name: retool
    app.kubernetes.io/instance: foo
    app.kubernetes.io/managed-by: Helm
spec:
  replicas: 2
  selector:
    matchLabels:
      app.kubernetes.io/name: retool
      app.kubernetes.io/instance: foo
  revisionHistoryLimit: 3
  template:
    metadata:
--
  name: foo-retool-jobs-runner
  labels:
    helm.sh/chart: retool-6.0.7
    app.kubernetes.io/name: retool
    app.kubernetes.io/instance: foo
    app.kubernetes.io/managed-by: Helm
spec:
  replicas: 1
  selector:
    matchLabels:
      app.kubernetes.io/name: retool-jobs-runner
      app.kubernetes.io/instance: foo
  revisionHistoryLimit: 3
  template:
    metadata:
--

--set replicaCount=1

$helm template -f ~/retool-helm/charts/retool/values.yaml foo ~/retool-helm/charts/retool --set config.encryptionKey="foo" --set image.tag="5.6.10" --set replicaCount=1  --debug | rg replicas -C 7

install.go:192: [debug] Original chart version: ""
install.go:209: [debug] CHART PATH: /Users/avimoondra/retool-helm/charts/retool

  name: foo-retool
  labels:
    helm.sh/chart: retool-6.0.7
    app.kubernetes.io/name: retool
    app.kubernetes.io/instance: foo
    app.kubernetes.io/managed-by: Helm
spec:
  replicas: 1
  selector:
    matchLabels:
      app.kubernetes.io/name: retool
      app.kubernetes.io/instance: foo
  revisionHistoryLimit: 3
  template:
    metadata:
--

@avimoondra avimoondra force-pushed the avimoondra/support-1-replica-with-jobs-runner branch from 9cde13a to aa6f5c3 Compare November 19, 2023 16:15
@avimoondra avimoondra merged commit 11ffe2a into main Nov 30, 2023
12 checks passed
@avimoondra avimoondra deleted the avimoondra/support-1-replica-with-jobs-runner branch November 30, 2023 18:45
@avimoondra avimoondra mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants