-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new internal worker + worker/temporal validations #129
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly same as
But based on https://github.com/tryretool/retool_development/pull/35620
updating env vars
- name: SERVICE_TYPE
value: INTERNAL_TEMPORAL_WORKER
and ports open on 3015 for health checks. https://github.com/tryretool/retool-helm/blob/main/charts/retool/templates/deployment_workflows_worker.yaml
3e1daf4
to
e4d1452
Compare
{{- if not (or (not (.Values.internalWorker.enabled)) (and (.Values.internalWorker.enabled) (or (include "retool.temporal.enabled" .) (include "retool.workflows.enabled" .)))) -}} | ||
internalWorker: | ||
Internal worker is enabled (via internalWorker.enabled), but Temporal is not enabled via retool-temporal-services-helm.enabled or workflows.temporal.enabled or via Retool's Managed Temporal for Retool Workflows (via workflows.enabled explicitly, or workflows.enabled implicitly based on image.tag > 3.6.11) | ||
{{- end -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if internalWorker is NOT enabled - validation ✅
if internalWork is enabled AND (some temporal is enabled OR workflows is enabled, with potential of using retool-managed temporal configured in-app) - validation ✅
will take this on |
93e6d30
to
0318ae5
Compare
workflows worker on based on version, internal worker off. ✅
workflows worker on version, internalWorker on ✅
workflows worker off based on version, internalWorker on -- validation error! ❌
workflows worker off based on version, internalWorker on + temporal configured ✅