[dev] [tofikwest] fix/cloud-reconnect-oauth-clear#2546
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
1 issue found across 7 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/app/src/hooks/use-integration-platform.ts">
<violation number="1" location="apps/app/src/hooks/use-integration-platform.ts:608">
P2: The `api.get` type parameter should include `meta` to match the SWR response type. Without it, `response.data` is typed as `{ services: ConnectionServiceItem[] }` and doesn't reflect the `meta` field the API actually returns, making the type contract misleading.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- fix GCP setup false positives by validating real SCC findings-read capability before surfacing required-step failures\n- fix Integrations page connection state selection to prefer active/newest connection per provider\n- add explicit GCP service-detection readiness metadata and UX to avoid temporary misleading service counts/states\n- keep GCP setup checks accessible after initial auto-scan via a Setup status entry point in Cloud Tests\n\n## Validation\n- apps/api: bun run build\n- apps/app: bun run test -- 'src/app/(app)/[orgId]/integrations/components/PlatformIntegrations.test.tsx'\n- apps/app: bun run test -- 'src/app/(app)/[orgId]/cloud-tests/components/GcpSetupGuide.test.tsx'\n
Summary by cubic
Improve GCP onboarding with service-detection readiness metadata and clear UI states, and keep GCP setup checks accessible after connect. Prevent false setup failures by verifying SCC read capability before showing required-step errors.
New Features
metawithproviderSlug,source(legacy-enabled|detected|manifest-default),detectionReady,detectionCompletedAt; backend setsserviceDetectionCompletedAtwhen detection finishes.Bug Fixes
enabledByDefaultuntil detection completes; remove GCP-only auto-enable to avoid misleading states.useConnectionServicestypes; returnmetato components.Written for commit 223b83f. Summary will update on new commits.