Skip to content

[dev] [tofikwest] fix/cloud-reconnect-oauth-clear#2546

Merged
tofikwest merged 3 commits intomainfrom
fix/cloud-reconnect-oauth-clear
Apr 14, 2026
Merged

[dev] [tofikwest] fix/cloud-reconnect-oauth-clear#2546
tofikwest merged 3 commits intomainfrom
fix/cloud-reconnect-oauth-clear

Conversation

@tofikwest
Copy link
Copy Markdown
Contributor

@tofikwest tofikwest commented Apr 14, 2026

Summary\n- fix GCP setup false positives by validating real SCC findings-read capability before surfacing required-step failures\n- fix Integrations page connection state selection to prefer active/newest connection per provider\n- add explicit GCP service-detection readiness metadata and UX to avoid temporary misleading service counts/states\n- keep GCP setup checks accessible after initial auto-scan via a Setup status entry point in Cloud Tests\n\n## Validation\n- apps/api: bun run build\n- apps/app: bun run test -- 'src/app/(app)/[orgId]/integrations/components/PlatformIntegrations.test.tsx'\n- apps/app: bun run test -- 'src/app/(app)/[orgId]/cloud-tests/components/GcpSetupGuide.test.tsx'\n


Summary by cubic

Improve GCP onboarding with service-detection readiness metadata and clear UI states, and keep GCP setup checks accessible after connect. Prevent false setup failures by verifying SCC read capability before showing required-step errors.

  • New Features

    • Connection services API returns meta with providerSlug, source (legacy-enabled | detected | manifest-default), detectionReady, detectionCompletedAt; backend sets serviceDetectionCompletedAt when detection finishes.
    • UI shows “Detecting active GCP services…” in Services tab, Scheduled Scan popover, and Integrations detail; hides service counts/toggles until ready. Adds a “Setup status” dialog in Cloud Tests to view and re-run the GCP setup guide.
  • Bug Fixes

    • Default to manifest enabledByDefault until detection completes; remove GCP-only auto-enable to avoid misleading states.
    • Validate SCC findings-read before surfacing GCP required-step failures.
    • Prefer the newest active connection per provider on the Integrations page.
    • Align services API response with useConnectionServices types; return meta to components.

Written for commit 223b83f. Summary will update on new commits.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Apr 14, 2026 1:23am
comp-framework-editor Ready Ready Preview, Comment Apr 14, 2026 1:23am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
portal Skipped Skipped Apr 14, 2026 1:23am

Request Review

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 7 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/app/src/hooks/use-integration-platform.ts">

<violation number="1" location="apps/app/src/hooks/use-integration-platform.ts:608">
P2: The `api.get` type parameter should include `meta` to match the SWR response type. Without it, `response.data` is typed as `{ services: ConnectionServiceItem[] }` and doesn't reflect the `meta` field the API actually returns, making the type contract misleading.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

@vercel vercel bot temporarily deployed to Preview – portal April 14, 2026 01:20 Inactive
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Requires human review: Modifies core logic for cloud service detection and integration states, which requires domain context to verify edge cases in the GCP onboarding flow.

@tofikwest tofikwest merged commit 8854953 into main Apr 14, 2026
11 checks passed
@tofikwest tofikwest deleted the fix/cloud-reconnect-oauth-clear branch April 14, 2026 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant