Skip to content

[dev] [tofikwest] fix/cloud-reconnect-oauth-clear#2545

Merged
tofikwest merged 3 commits intomainfrom
fix/cloud-reconnect-oauth-clear
Apr 14, 2026
Merged

[dev] [tofikwest] fix/cloud-reconnect-oauth-clear#2545
tofikwest merged 3 commits intomainfrom
fix/cloud-reconnect-oauth-clear

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Apr 14, 2026

This is an automated pull request to merge fix/cloud-reconnect-oauth-clear into dev.
It was created by the [Auto Pull Request] action.


Summary by cubic

Use capability-based checks for GCP SCC setup, choose the highest-priority connection per provider, and default GCP services to enabled until detection runs. This fixes false “Connect” prompts and prevents GCP services showing OFF right after OAuth.

  • Bug Fixes
    • API (GCP): If org findings are readable via SCC v2, mark “Enable SCC API” and “Grant Findings Viewer” as successful. Added canReadFindings.
    • App: When multiple connection rows exist, pick the highest-priority status (active > pending > error > paused > disconnected), then newest by createdAt. Prevents “Connect” when an active row exists.
    • API (Integrations): For gcp, enable services by default when detection data isn’t available (unless explicitly disabled).

Written for commit faaf422. Summary will update on new commits.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
comp-framework-editor Ready Ready Preview, Comment Apr 14, 2026 0:41am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
app Skipped Skipped Apr 14, 2026 0:41am
portal Skipped Skipped Apr 14, 2026 0:41am

Request Review

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Requires human review: This PR modifies core business logic for GCP integration setup and connection status prioritization, which requires human review to ensure correctness and architectural consistency.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Requires human review: This PR modifies business logic for integration connection prioritization and introduces new GCP API capability checks, which are functional changes to the core integration flow.

@vercel vercel bot temporarily deployed to Preview – portal April 14, 2026 00:40 Inactive
@vercel vercel bot temporarily deployed to Preview – app April 14, 2026 00:40 Inactive
@tofikwest tofikwest merged commit c84480e into main Apr 14, 2026
11 checks passed
@tofikwest tofikwest deleted the fix/cloud-reconnect-oauth-clear branch April 14, 2026 00:41
@claudfuen
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants