-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Update OpenAPI schema: Remove additionalProperties constraint on data property #140
Conversation
WalkthroughThe pull request involves modifications to the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/libs/Cohere/openapi.yaml (2)
12143-12143
: Documentation inconsistency in pluralityThe description changed from "documents" to "document" (singular). This seems inconsistent with the property being an object that can contain multiple entries.
Consider updating to:
- description: "A relevant document that the model can cite to generate a more accurate reply. Each document is a string-any dictionary.\n" + description: "Relevant documents that the model can cite to generate a more accurate reply. Each document is a string-any dictionary.\n"
12143-12143
: Consider adding schema validation for common typesWhile allowing any type provides flexibility, consider adding a pattern or enum for commonly expected value types to guide API consumers.
Example addition:
oneOf: - type: string - type: number - type: boolean - type: object additionalProperties: true
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
src/libs/Cohere/Generated/Cohere.Models.Document.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.Models.DocumentData.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/JsonSerializerContextTypes.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/Cohere/openapi.yaml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Test / Build, test and publish
🔇 Additional comments (1)
src/libs/Cohere/openapi.yaml (1)
12143-12143
:⚠️ Potential issueBreaking Change: Schema modification affects API contract
The change from a string-string to string-any dictionary is a breaking change that could impact existing clients. This modification allows for more flexible value types but might break implementations that expect string values.
Let's verify the impact on existing implementations:
Summary by CodeRabbit